[GitHub] spark pull request #19309: [SPARK-19558][sql] Add config key to register Que...

[gatorsmile <gi...@git.apache.org>]

Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19309#discussion_r143346651
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/util/ExecutionListenerManagerSuite.scala ---
    @@ -0,0 +1,69 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.sql.util
    +
    +import java.util.concurrent.atomic.AtomicInteger
    +
    +import org.apache.spark._
    +import org.apache.spark.sql.execution.QueryExecution
    +import org.apache.spark.sql.internal.StaticSQLConf._
    +
    +class ExecutionListenerManagerSuite extends SparkFunSuite {
    +
    +  import CountingQueryExecutionListener._
    +
    +  test("register query execution listeners using configuration") {
    +    val conf = new SparkConf(false)
    +      .set(QUERY_EXECUTION_LISTENERS, Seq(classOf[CountingQueryExecutionListener].getName()))
    --- End diff --
    
    Now, this test only has one single listener whose constructor has zero arg. Could you add one more with a `SparkConf` arg in the constructor?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org