You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Jarek Cecho <ja...@apache.org> on 2011/12/05 17:14:49 UTC
Review Request: FLUME-863: Use of unknown sink type leads to
NullPointerException
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3009/
-----------------------------------------------------------
Review request for Flume and Eric Sammer.
Summary
-------
I've just add condition for testing null returned from calling getSinkFactory() and rising exception in case that it's really null.
This addresses bug FLUME-863.
https://issues.apache.org/jira/browse/FLUME-863
Diffs
-----
/branches/flume-728/flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java 1205797
Diff: https://reviews.apache.org/r/3009/diff
Testing
-------
Thanks,
Jarek
Re: Review Request: FLUME-863: Use of unknown sink type leads to
NullPointerException
Posted by Jarek Cecho <ja...@apache.org>.
> On 2011-12-19 18:42:32, Prasad Mujumdar wrote:
> > lgtm
Thank you for the review. Patch is already attached to JIRA, feel free to commit it.
Jarcec
- Jarek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3009/#review3977
-----------------------------------------------------------
On 2011-12-05 16:14:49, Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3009/
> -----------------------------------------------------------
>
> (Updated 2011-12-05 16:14:49)
>
>
> Review request for Flume and Eric Sammer.
>
>
> Summary
> -------
>
> I've just add condition for testing null returned from calling getSinkFactory() and rising exception in case that it's really null.
>
>
> This addresses bug FLUME-863.
> https://issues.apache.org/jira/browse/FLUME-863
>
>
> Diffs
> -----
>
> /branches/flume-728/flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java 1205797
>
> Diff: https://reviews.apache.org/r/3009/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jarek
>
>
Re: Review Request: FLUME-863: Use of unknown sink type leads to
NullPointerException
Posted by Prasad Mujumdar <pr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3009/#review3977
-----------------------------------------------------------
Ship it!
lgtm
- Prasad
On 2011-12-05 16:14:49, Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3009/
> -----------------------------------------------------------
>
> (Updated 2011-12-05 16:14:49)
>
>
> Review request for Flume and Eric Sammer.
>
>
> Summary
> -------
>
> I've just add condition for testing null returned from calling getSinkFactory() and rising exception in case that it's really null.
>
>
> This addresses bug FLUME-863.
> https://issues.apache.org/jira/browse/FLUME-863
>
>
> Diffs
> -----
>
> /branches/flume-728/flume-ng-node/src/main/java/org/apache/flume/conf/properties/PropertiesFileConfigurationProvider.java 1205797
>
> Diff: https://reviews.apache.org/r/3009/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jarek
>
>