You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2019/07/15 17:36:33 UTC

[GitHub] [mynewt-nimble] ccollins476ad commented on a change in pull request #503: nimble/gatt: Queuing of Partial Reading in ble_gattc_read_long

ccollins476ad commented on a change in pull request #503: nimble/gatt: Queuing of Partial Reading in ble_gattc_read_long
URL: https://github.com/apache/mynewt-nimble/pull/503#discussion_r303552686
 
 

 ##########
 File path: nimble/host/include/host/ble_gatt.h
 ##########
 @@ -320,7 +320,7 @@ int ble_gattc_read_by_uuid(uint16_t conn_handle, uint16_t start_handle,
  * @param cb_arg                The optional argument to pass to the callback
  *                                  function.
  *
- * @return                      0 on success; nonzero on failure.
+ * @return                      BLE_HS_EDONE on success; nonzero on failure.
 
 Review comment:
   IMO...
   
   When possible, functions should return 0 on success.  `BLE_HS_EDONE` is a "necessary evil" for when there are multiple ways to succeed.  In this case, success can mean only one thing, so we should use 0.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services