You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/06/18 10:19:59 UTC
[GitHub] [pulsar] fantapsody opened a new pull request #7300: [pulsar-perf]Supports `tlsAllowInsecureConnection` in pulsar-perf produce/consume/read.
fantapsody opened a new pull request #7300:
URL: https://github.com/apache/pulsar/pull/7300
### Motivation
Add support of `tlsAllowInsecureConnection` config to the command-line tool `pulsar-perf`, to support `produce/consume/read` performance tests to clusters with insecure tls connections.
### Modifications
*Describe the modifications you've done.*
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API: (yes / no)
- The schema: (yes / no / don't know)
- The default values of configurations: (yes / no)
- The wire protocol: (yes / no)
- The rest endpoints: (yes / no)
- The admin cli options: (yes / no)
- Anything that affects deployment: (yes / no / don't know)
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Huanli-Meng commented on a change in pull request #7300: [pulsar-perf] Supports `tlsAllowInsecureConnection` in pulsar-perf produce/consume/read.
Posted by GitBox <gi...@apache.org>.
Huanli-Meng commented on a change in pull request #7300:
URL: https://github.com/apache/pulsar/pull/7300#discussion_r442561401
##########
File path: site2/docs/reference-cli-tools.md
##########
@@ -494,7 +496,7 @@ Options
|`-i`, `--stats-interval-seconds`|Statistics interval seconds. If 0, statistics will be disabled.|0|
|`--trust-cert-file`|Path for the trusted TLS certificate file||
|`--use-tls`|Use TLS encryption on the connection|false|
-
+|`--tls-allow-insecure`|Allow insecure tls connection||
Review comment:
```suggestion
|`--tls-allow-insecure`|Allow insecure TLS connection.||
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Huanli-Meng commented on a change in pull request #7300: [pulsar-perf] Supports `tlsAllowInsecureConnection` in pulsar-perf produce/consume/read.
Posted by GitBox <gi...@apache.org>.
Huanli-Meng commented on a change in pull request #7300:
URL: https://github.com/apache/pulsar/pull/7300#discussion_r442561147
##########
File path: site2/docs/reference-cli-tools.md
##########
@@ -468,6 +469,7 @@ Options
|`-time`, `--test-duration`|Test duration in secs. If set to 0, it will keep publishing.|0|
|`--trust-cert-file`|Path for the trusted TLS certificate file||
|`--warmup-time`|Warm-up time in seconds|1|
+|`--tls-allow-insecure`|Allow insecure tls connection||
Review comment:
```suggestion
|`--tls-allow-insecure`|Allow insecure TLS connection.||
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Huanli-Meng commented on a change in pull request #7300: [pulsar-perf] Supports `tlsAllowInsecureConnection` in pulsar-perf produce/consume/read.
Posted by GitBox <gi...@apache.org>.
Huanli-Meng commented on a change in pull request #7300:
URL: https://github.com/apache/pulsar/pull/7300#discussion_r442561058
##########
File path: site2/docs/reference-cli-tools.md
##########
@@ -431,6 +431,7 @@ Options
|`-st`, `--subscription-type`|Subscriber type. Possible values are Exclusive, Shared, Failover, Key_Shared.|Exclusive|
|`-sp`, `--subscription-position`|Subscriber position. Possible values are Latest, Earliest.|Latest|
|`--trust-cert-file`|Path for the trusted TLS certificate file||
+|`--tls-allow-insecure`|Allow insecure tls connection||
Review comment:
```suggestion
|`--tls-allow-insecure`|Allow insecure TLS connection.||
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie merged pull request #7300: [pulsar-perf] Supports `tlsAllowInsecureConnection` in pulsar-perf produce/consume/read.
Posted by GitBox <gi...@apache.org>.
sijie merged pull request #7300:
URL: https://github.com/apache/pulsar/pull/7300
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jiazhai commented on pull request #7300: [pulsar-perf] Supports `tlsAllowInsecureConnection` in pulsar-perf produce/consume/read.
Posted by GitBox <gi...@apache.org>.
jiazhai commented on pull request #7300:
URL: https://github.com/apache/pulsar/pull/7300#issuecomment-652502576
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org