You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "covidium (via GitHub)" <gi...@apache.org> on 2023/08/09 10:06:59 UTC
[GitHub] [airflow] covidium opened a new pull request, #33251: Add new RdsStartExportTaskOperator parameters
covidium opened a new pull request, #33251:
URL: https://github.com/apache/airflow/pull/33251
Add support to specify max_attempts and check_interval for RdsStartExportTaskOperator
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] vincbeck commented on a diff in pull request #33251: Add new RdsStartExportTaskOperator parameters
Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck commented on code in PR #33251:
URL: https://github.com/apache/airflow/pull/33251#discussion_r1288779402
##########
airflow/providers/amazon/aws/operators/rds.py:
##########
@@ -351,6 +351,8 @@ def __init__(
s3_prefix: str = "",
export_only: list[str] | None = None,
wait_for_completion: bool = True,
+ waiter_interval: int = 30,
+ waiter_max_attempts: int = 40,
Review Comment:
Please add these to docstring as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] o-nikolas commented on a diff in pull request #33251: Add new RdsStartExportTaskOperator parameters
Posted by "o-nikolas (via GitHub)" <gi...@apache.org>.
o-nikolas commented on code in PR #33251:
URL: https://github.com/apache/airflow/pull/33251#discussion_r1290410027
##########
airflow/providers/amazon/aws/operators/rds.py:
##########
@@ -351,6 +353,8 @@ def __init__(
s3_prefix: str = "",
export_only: list[str] | None = None,
wait_for_completion: bool = True,
+ waiter_interval: int = 30,
+ waiter_max_attempts: int = 40,
Review Comment:
Cool, fair enough, lgtm!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] covidium commented on a diff in pull request #33251: Add new RdsStartExportTaskOperator parameters
Posted by "covidium (via GitHub)" <gi...@apache.org>.
covidium commented on code in PR #33251:
URL: https://github.com/apache/airflow/pull/33251#discussion_r1289668698
##########
airflow/providers/amazon/aws/operators/rds.py:
##########
@@ -351,6 +353,8 @@ def __init__(
s3_prefix: str = "",
export_only: list[str] | None = None,
wait_for_completion: bool = True,
+ waiter_interval: int = 30,
+ waiter_max_attempts: int = 40,
Review Comment:
That's the default waiting time defined in the hook wait_for_export_task_state. I've added these settings as in us-east-1 we're getting a 20 minutes delay before the actual export task starts, resulting in the failure of the DAG, so I need a way to modify those values and increase them over 30 minutes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #33251: Add new RdsStartExportTaskOperator parameters
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #33251:
URL: https://github.com/apache/airflow/pull/33251#issuecomment-1675055295
Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] vincbeck merged pull request #33251: Add new RdsStartExportTaskOperator parameters
Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck merged PR #33251:
URL: https://github.com/apache/airflow/pull/33251
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] covidium commented on a diff in pull request #33251: Add new RdsStartExportTaskOperator parameters
Posted by "covidium (via GitHub)" <gi...@apache.org>.
covidium commented on code in PR #33251:
URL: https://github.com/apache/airflow/pull/33251#discussion_r1289107832
##########
airflow/providers/amazon/aws/operators/rds.py:
##########
@@ -351,6 +351,8 @@ def __init__(
s3_prefix: str = "",
export_only: list[str] | None = None,
wait_for_completion: bool = True,
+ waiter_interval: int = 30,
+ waiter_max_attempts: int = 40,
Review Comment:
Added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] vincbeck commented on a diff in pull request #33251: Add new RdsStartExportTaskOperator parameters
Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck commented on code in PR #33251:
URL: https://github.com/apache/airflow/pull/33251#discussion_r1290203531
##########
airflow/providers/amazon/aws/operators/rds.py:
##########
@@ -351,6 +353,8 @@ def __init__(
s3_prefix: str = "",
export_only: list[str] | None = None,
wait_for_completion: bool = True,
+ waiter_interval: int = 30,
+ waiter_max_attempts: int = 40,
Review Comment:
Agree, we have to set these values to be backward compatible
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #33251: Add new RdsStartExportTaskOperator parameters
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #33251:
URL: https://github.com/apache/airflow/pull/33251#issuecomment-1671039701
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
- Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] o-nikolas commented on a diff in pull request #33251: Add new RdsStartExportTaskOperator parameters
Posted by "o-nikolas (via GitHub)" <gi...@apache.org>.
o-nikolas commented on code in PR #33251:
URL: https://github.com/apache/airflow/pull/33251#discussion_r1289655959
##########
airflow/providers/amazon/aws/operators/rds.py:
##########
@@ -351,6 +353,8 @@ def __init__(
s3_prefix: str = "",
export_only: list[str] | None = None,
wait_for_completion: bool = True,
+ waiter_interval: int = 30,
+ waiter_max_attempts: int = 40,
Review Comment:
20 minutes by default feels like a long time. Is that reasonable for this context?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org