You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@harmony.apache.org by Alexey Petrenko <al...@gmail.com> on 2007/02/02 16:35:44 UTC
[jira][general] Patch descriptions
I've faced the following problem while reviewing suggested patches:
the patches does not have descriptions. It is easy to understand the
patch if it is doing something simple. Like parameters check.
But in more complicated cases description would be great.
So I vote for including patch description requirement to the "Good
issue resolution guideline" [1].
Any concerns or objections?
SY, Alexey
[1] http://harmony.apache.org/issue_resolution_guideline.html
Re: [jira][general] Patch descriptions
Posted by Alexey Petrenko <al...@gmail.com>.
2007/2/2, Naveen Neelakantam <ne...@uiuc.edu>:
>
> On Feb 2, 2007, at 9:42 AM, Geir Magnusson Jr. wrote:
>
> >
> > On Feb 2, 2007, at 10:35 AM, Alexey Petrenko wrote:
> >
> >> I've faced the following problem while reviewing suggested patches:
> >> the patches does not have descriptions. It is easy to understand the
> >> patch if it is doing something simple. Like parameters check.
> >> But in more complicated cases description would be great.
> >>
> >> So I vote for including patch description requirement to the "Good
> >> issue resolution guideline" [1].
> >>
> >> Any concerns or objections?
> >>
> >
> > None. And besides documenting it, feel free to push back on
> > patches that don't have good descriptions.
>
> Before an issue is pushed back, could an email be sent to the
> reporter? Or maybe a comment could be placed in the JIRA saying that
> the issue is being pushed back?
Sure!
SY, Alexey
> I am *trying* to be helpful when I report bugs, but if I'm doing a
> bad job I want someone to let me know. It's hard to change if you
> don't know something is wrong.
>
> Naveen
>
> > geir
> >
> >> SY, Alexey
> >>
> >> [1] http://harmony.apache.org/issue_resolution_guideline.html
> >
>
>
Re: [jira][general] Patch descriptions
Posted by "Geir Magnusson Jr." <ge...@pobox.com>.
On Feb 2, 2007, at 1:36 PM, Naveen Neelakantam wrote:
>
> On Feb 2, 2007, at 9:42 AM, Geir Magnusson Jr. wrote:
>
>>
>> On Feb 2, 2007, at 10:35 AM, Alexey Petrenko wrote:
>>
>>> I've faced the following problem while reviewing suggested patches:
>>> the patches does not have descriptions. It is easy to understand the
>>> patch if it is doing something simple. Like parameters check.
>>> But in more complicated cases description would be great.
>>>
>>> So I vote for including patch description requirement to the "Good
>>> issue resolution guideline" [1].
>>>
>>> Any concerns or objections?
>>>
>>
>> None. And besides documenting it, feel free to push back on
>> patches that don't have good descriptions.
>
> Before an issue is pushed back, could an email be sent to the
> reporter? Or maybe a comment could be placed in the JIRA saying
> that the issue is being pushed back?
Sorry. I meant "push back" colloquially, in exactly that sense, not
to close or discard (immediately).
>
> I am *trying* to be helpful when I report bugs, but if I'm doing a
> bad job I want someone to let me know. It's hard to change if you
> don't know something is wrong.
Of course. That's what I meant.
geir
>
> Naveen
>
>> geir
>>
>>> SY, Alexey
>>>
>>> [1] http://harmony.apache.org/issue_resolution_guideline.html
>>
>
Re: [jira][general] Patch descriptions
Posted by Naveen Neelakantam <ne...@uiuc.edu>.
On Feb 2, 2007, at 9:42 AM, Geir Magnusson Jr. wrote:
>
> On Feb 2, 2007, at 10:35 AM, Alexey Petrenko wrote:
>
>> I've faced the following problem while reviewing suggested patches:
>> the patches does not have descriptions. It is easy to understand the
>> patch if it is doing something simple. Like parameters check.
>> But in more complicated cases description would be great.
>>
>> So I vote for including patch description requirement to the "Good
>> issue resolution guideline" [1].
>>
>> Any concerns or objections?
>>
>
> None. And besides documenting it, feel free to push back on
> patches that don't have good descriptions.
Before an issue is pushed back, could an email be sent to the
reporter? Or maybe a comment could be placed in the JIRA saying that
the issue is being pushed back?
I am *trying* to be helpful when I report bugs, but if I'm doing a
bad job I want someone to let me know. It's hard to change if you
don't know something is wrong.
Naveen
> geir
>
>> SY, Alexey
>>
>> [1] http://harmony.apache.org/issue_resolution_guideline.html
>
Re: [jira][general] Patch descriptions
Posted by "Geir Magnusson Jr." <ge...@pobox.com>.
On Feb 2, 2007, at 10:35 AM, Alexey Petrenko wrote:
> I've faced the following problem while reviewing suggested patches:
> the patches does not have descriptions. It is easy to understand the
> patch if it is doing something simple. Like parameters check.
> But in more complicated cases description would be great.
>
> So I vote for including patch description requirement to the "Good
> issue resolution guideline" [1].
>
> Any concerns or objections?
>
None. And besides documenting it, feel free to push back on patches
that don't have good descriptions.
geir
> SY, Alexey
>
> [1] http://harmony.apache.org/issue_resolution_guideline.html