You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "elon-X (via GitHub)" <gi...@apache.org> on 2024/04/11 04:00:15 UTC
[PR] [FLINK-35064] Update Pulsar dependency to solve the conflict of com.f… [flink-connector-pulsar]
elon-X opened a new pull request, #88:
URL: https://github.com/apache/flink-connector-pulsar/pull/88
This PR fixes the conflict of com.fasterxml.jackson.annotation.JsonFormat$Value
## Purpose of the change
fixes the conflict of com.fasterxml.jackson.annotation.JsonFormat$Value
## Brief change log
update pom.xml to relocate the 'com.fasterxml' classes to 'org.apache.pulsar.shade.com.fasterxml'
## Verifying this change
execute 'mvn clean package -DskipTests', then jar -tf flink-sql-connector-pulsar-4.2-SNAPSHOT.jar | grep 'com.fasterxml', the original 'com.fasterxml' classes are now located under 'org.apache.pulsar.shade.com.fasterxml'
## Significant changes
*(Please check any boxes [x] if the answer is "yes". You can first publish the PR and check them afterwards, for
convenience.)*
- [ ] Dependencies have been added or upgraded
- [ ] Public API has been changed (Public API is any class annotated with `@Public(Evolving)`)
- [ ] Serializers have been changed
- [ ] New feature has been introduced
- If yes, how is this documented? (not applicable / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-35064] Update Pulsar dependency to solve the conflict of com.f… [flink-connector-pulsar]
Posted by "syhily (via GitHub)" <gi...@apache.org>.
syhily commented on PR #88:
URL: https://github.com/apache/flink-connector-pulsar/pull/88#issuecomment-2055227659
Sorry, I don't think this PR is accepted, indeed. IIUC, the `pulsar-client-all` bundle a Jackson internally with a package named `org.apache.pulsar.shade.com.fasterxml`. The normal jackson can't be shaded into the same package name. Or it may cause more severe issues in class conflicting. I don't think this is a good idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-35064] Update Pulsar dependency to solve the conflict of com.f… [flink-connector-pulsar]
Posted by "syhily (via GitHub)" <gi...@apache.org>.
syhily commented on PR #88:
URL: https://github.com/apache/flink-connector-pulsar/pull/88#issuecomment-2055283881
The root cause is from pulsar client side with the Jackson shading issues. Shade a jackson causes a lot of issues. I think we should ask pulsar client not to shade the jackson.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-35064] Update Pulsar dependency to solve the conflict of com.f… [flink-connector-pulsar]
Posted by "elon-X (via GitHub)" <gi...@apache.org>.
elon-X commented on PR #88:
URL: https://github.com/apache/flink-connector-pulsar/pull/88#issuecomment-2054774574
@MartijnVisser @syhily Could you please help approve this PR when you have some free time? Thank you very much.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org