You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by GitBox <gi...@apache.org> on 2020/06/17 14:24:11 UTC
[GitHub] [tomcat] rotty3000 opened a new pull request #303: Fix BZ 64532 - update to bnd 5.1.1
rotty3000 opened a new pull request #303:
URL: https://github.com/apache/tomcat/pull/303
Signed-off-by: Raymond Augé <ro...@apache.org>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] rotty3000 commented on a change in pull request #303: Fix BZ 64532 - update to bnd 5.1.1
Posted by GitBox <gi...@apache.org>.
rotty3000 commented on a change in pull request #303:
URL: https://github.com/apache/tomcat/pull/303#discussion_r441676683
##########
File path: build.properties.default
##########
@@ -286,14 +286,14 @@ saaj-api.home=${base.path}/saaj-api-${saaj-api.version}
saaj-api.jar=${saaj-api.home}/saaj-api-${saaj-api.version}.jar
saaj-api.loc=${base-maven.loc}/javax/xml/soap/saaj-api/${saaj-api.version}/saaj-api-${saaj-api.version}.jar
-# ----- bnd & bndlib, version 4.0.0 or later -----
+# ----- bnd, version 5.1.1 or later -----
Review comment:
There is that yes, but also in 5.1.1 specifically there is a bug fix for correctly generating the Manifest Name section which I'd like to use for the Spec jars.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] rotty3000 commented on a change in pull request #303: Fix BZ 64532 - update to bnd 5.1.1
Posted by GitBox <gi...@apache.org>.
rotty3000 commented on a change in pull request #303:
URL: https://github.com/apache/tomcat/pull/303#discussion_r441943416
##########
File path: build.properties.default
##########
@@ -286,14 +286,14 @@ saaj-api.home=${base.path}/saaj-api-${saaj-api.version}
saaj-api.jar=${saaj-api.home}/saaj-api-${saaj-api.version}.jar
saaj-api.loc=${base-maven.loc}/javax/xml/soap/saaj-api/${saaj-api.version}/saaj-api-${saaj-api.version}.jar
-# ----- bnd & bndlib, version 4.0.0 or later -----
+# ----- bnd, version 5.1.1 or later -----
# ----- provides OSGI metadata for JARs -----
-bnd.version=5.1.0
+bnd.version=5.1.1
# checksums for biz.aQute.bnd-5.1.0.jar
Review comment:
Done!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] markt-asf commented on a change in pull request #303: Fix BZ 64532 - update to bnd 5.1.1
Posted by GitBox <gi...@apache.org>.
markt-asf commented on a change in pull request #303:
URL: https://github.com/apache/tomcat/pull/303#discussion_r441680635
##########
File path: build.properties.default
##########
@@ -286,14 +286,14 @@ saaj-api.home=${base.path}/saaj-api-${saaj-api.version}
saaj-api.jar=${saaj-api.home}/saaj-api-${saaj-api.version}.jar
saaj-api.loc=${base-maven.loc}/javax/xml/soap/saaj-api/${saaj-api.version}/saaj-api-${saaj-api.version}.jar
-# ----- bnd & bndlib, version 4.0.0 or later -----
+# ----- bnd, version 5.1.1 or later -----
Review comment:
Fair enough. Just checking.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] rotty3000 commented on pull request #303: Fix BZ 64532 - update to bnd 5.1.1
Posted by GitBox <gi...@apache.org>.
rotty3000 commented on pull request #303:
URL: https://github.com/apache/tomcat/pull/303#issuecomment-646637527
@markt-asf did I miss any other changes you wanted to see?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] markt-asf commented on a change in pull request #303: Fix BZ 64532 - update to bnd 5.1.1
Posted by GitBox <gi...@apache.org>.
markt-asf commented on a change in pull request #303:
URL: https://github.com/apache/tomcat/pull/303#discussion_r441648490
##########
File path: build.properties.default
##########
@@ -286,14 +286,14 @@ saaj-api.home=${base.path}/saaj-api-${saaj-api.version}
saaj-api.jar=${saaj-api.home}/saaj-api-${saaj-api.version}.jar
saaj-api.loc=${base-maven.loc}/javax/xml/soap/saaj-api/${saaj-api.version}/saaj-api-${saaj-api.version}.jar
-# ----- bnd & bndlib, version 4.0.0 or later -----
+# ----- bnd, version 5.1.1 or later -----
Review comment:
Is this really an increase in the minimum version? Or is 5.1.0 (with the fix for the Java 15 bug) sufficient?
##########
File path: build.properties.default
##########
@@ -286,14 +286,14 @@ saaj-api.home=${base.path}/saaj-api-${saaj-api.version}
saaj-api.jar=${saaj-api.home}/saaj-api-${saaj-api.version}.jar
saaj-api.loc=${base-maven.loc}/javax/xml/soap/saaj-api/${saaj-api.version}/saaj-api-${saaj-api.version}.jar
-# ----- bnd & bndlib, version 4.0.0 or later -----
+# ----- bnd, version 5.1.1 or later -----
# ----- provides OSGI metadata for JARs -----
-bnd.version=5.1.0
+bnd.version=5.1.1
# checksums for biz.aQute.bnd-5.1.0.jar
Review comment:
You need to update the version in the comment for consistency.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] markt-asf merged pull request #303: Fix BZ 64532 - update to bnd 5.1.1
Posted by GitBox <gi...@apache.org>.
markt-asf merged pull request #303:
URL: https://github.com/apache/tomcat/pull/303
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org