[GitHub] k-wall commented on a change in pull request #2568: ARTEMIS-2262: Correlate management response messages with the request

[GitBox <gi...@apache.org>]

k-wall commented on a change in pull request #2568: ARTEMIS-2262: Correlate management response messages with the request
URL: https://github.com/apache/activemq-artemis/pull/2568#discussion_r260663401
 
 

 ##########
 File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/management/impl/ManagementServiceImpl.java
 ##########
 @@ -390,6 +393,11 @@ public ICoreMessage handleMessage(Message message) throws Exception {
       reply.setType(Message.TEXT_TYPE);
       reply.setReplyTo(message.getReplyTo());
 
+      String correlationId = getCorrelationIdentity(message);
+      if (correlationId != null) {
+         MessageUtil.setJMSCorrelationID(reply, correlationId);
 
 Review comment:
   @michaelandrepearce thanks for the feedback.   I'm inexperience in the Artemis code base but  think I understand what you mean.  I'll rework the patch once @clebertsuconic has had chance to comment on merits or otherwise of the use-case.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services