[GitHub] [geode] boglesby commented on a change in pull request #6036: GEODE-8856: Persist gateway-sender state

[GitBox <gi...@apache.org>]

boglesby commented on a change in pull request #6036:
URL: https://github.com/apache/geode/pull/6036#discussion_r605798695



##########
File path: geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/functions/GatewaySenderFunctionArgs.java
##########
@@ -47,6 +47,7 @@
   private final List<String> gatewayEventFilters;
   private final List<String> gatewayTransportFilters;
   private final Boolean enforceThreadsConnectSameReceiver;
+  private final String state;

Review comment:
       One of the problems with manual-start is that if it is set to true, it doesn't recover the sender's persistence files.
   
   The same is also true of state=stopped.
   
   This causes data regions to not be recovered in the parallel case since the data and queue regions are co-located.
   
   A warning like this is displayed:
   ```
   [warn 2021/04/01 09:32:47.877 PDT server-ln-1 <ColocationLogger for Trade> tid=0x3c] Persistent data recovery for region /Trade is prevented by offline colocated region
   	/ny_PARALLEL_GATEWAY_SENDER_QUEUE
   ```
   A test to cause this is:
   
   1. Start a server with a persistent region and sender
   2. Shutdown the server
   3. Set manual-start=true (either export / cluster configuration or modify xml)
   4. Restart the server
   
   If we allow a persistent, parallel sender to be created with state=stopped or even save the stopped state when the sender shuts down, we'll have the same problem. I'm not sure we should allow either of those cases.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org