[GitHub] [incubator-doris] wangbo commented on a change in pull request #8234: [Feature] Support pre-aggregation for quantile type

[GitBox <gi...@apache.org>]

wangbo commented on a change in pull request #8234:
URL: https://github.com/apache/incubator-doris/pull/8234#discussion_r816704629



##########
File path: be/src/olap/row_block.cpp
##########
@@ -89,8 +89,7 @@ void RowBlock::_compute_layout() {
         _field_offset_in_memory.push_back(memory_size);
 
         // All field has a nullbyte in memory
-        if (column.type() == OLAP_FIELD_TYPE_VARCHAR || column.type() == OLAP_FIELD_TYPE_HLL ||
-            column.type() == OLAP_FIELD_TYPE_CHAR || column.type() == OLAP_FIELD_TYPE_OBJECT ||column.type() == OLAP_FIELD_TYPE_STRING) {
+        if (column.is_slice_stored()) {

Review comment:
       Maybe ```is_variable_type```  be better than ```is_slice_stored``` ? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org