[GitHub] [pinot] amrishlal commented on a change in pull request #7830: Implement Multiple Predicate Execution (FILTER Clauses)

[GitBox <gi...@apache.org>]

amrishlal commented on a change in pull request #7830:
URL: https://github.com/apache/pinot/pull/7830#discussion_r765327106



##########
File path: pinot-core/src/test/java/org/apache/pinot/queries/InnerSegmentAggregationSingleValueQueriesTest.java
##########
@@ -49,27 +49,49 @@
       " GROUP BY column1, column3, column6, column7, column9, column11, column12, column17, column18";
 
   @Test
-  public void testAggregationOnly() {
-    String query = "SELECT" + AGGREGATION + " FROM testTable";

Review comment:
       Why are we modifying an existing test case. Is the existing test case no longer valid? If not, I would suggest leaving the existing test case as is and adding a new test case.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org