[jira] Commented: (MAPREDUCE-2381) JobTracker instrumentation not consistent about error handling

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAPREDUCE-2381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13006357#comment-13006357 ] 

Hadoop QA commented on MAPREDUCE-2381:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12473531/MAPREDUCE-2381.patch.txt
  against trunk revision 1080831.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    -1 contrib tests.  The patch failed contrib unit tests.

    +1 system test framework.  The patch passed system test framework compile.

Test results: https://hudson.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/138//testReport/
Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/138//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://hudson.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/138//console

This message is automatically generated.

> JobTracker instrumentation not consistent about error handling
> --------------------------------------------------------------
>
>                 Key: MAPREDUCE-2381
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2381
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>            Reporter: Philip Zeyliger
>            Assignee: Philip Zeyliger
>         Attachments: MAPREDUCE-2381.patch.txt
>
>
> In the current code, if the class specified by the JobTracker instrumentation config property is not there, the JobTracker fails to start with a ClassNotFound.  If it's there, but it can't load for whatever reason, the JobTracker continues with the default.  Having two different error-handling routes is a bit confusing; I propose to move one line so that it's consistent.  (On the TaskTracker instrumentation side, if any of the multiple instrumentations aren't available, the default is used.)
> The attached patch merely moves a line inside of the try block that's already there. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira