You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/11/22 05:10:35 UTC
[GitHub] [camel] gnodet opened a new pull request, #8756: Fix build problems
gnodet opened a new pull request, #8756:
URL: https://github.com/apache/camel/pull/8756
Maven 4 is a bit more restrictive, so the build should be cleaned a bit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] gnodet merged pull request #8756: Fix build problems
Posted by GitBox <gi...@apache.org>.
gnodet merged PR #8756:
URL: https://github.com/apache/camel/pull/8756
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on a diff in pull request #8756: Fix build problems
Posted by GitBox <gi...@apache.org>.
oscerd commented on code in PR #8756:
URL: https://github.com/apache/camel/pull/8756#discussion_r1028835809
##########
components/camel-aws/camel-aws2-cw/pom.xml:
##########
@@ -80,9 +80,5 @@
<type>test-jar</type>
<scope>test</scope>
</dependency>
- <dependency>
- <groupId>org.apache.camel</groupId>
- <artifactId>camel-health</artifactId>
- </dependency>
Review Comment:
This is needed for health check to work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] gnodet commented on a diff in pull request #8756: Fix build problems
Posted by GitBox <gi...@apache.org>.
gnodet commented on code in PR #8756:
URL: https://github.com/apache/camel/pull/8756#discussion_r1028840912
##########
components/camel-aws/camel-aws2-cw/pom.xml:
##########
@@ -80,9 +80,5 @@
<type>test-jar</type>
<scope>test</scope>
</dependency>
- <dependency>
- <groupId>org.apache.camel</groupId>
- <artifactId>camel-health</artifactId>
- </dependency>
Review Comment:
It's a dup. It's already defined above in the pom.
https://github.com/apache/camel/blob/fa84d456ab6a88db35ba7c1da1186d4e0a8c7868/components/camel-aws/camel-aws2-cw/pom.xml#L43-L46
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] gnodet commented on a diff in pull request #8756: Fix build problems
Posted by GitBox <gi...@apache.org>.
gnodet commented on code in PR #8756:
URL: https://github.com/apache/camel/pull/8756#discussion_r1028840912
##########
components/camel-aws/camel-aws2-cw/pom.xml:
##########
@@ -80,9 +80,5 @@
<type>test-jar</type>
<scope>test</scope>
</dependency>
- <dependency>
- <groupId>org.apache.camel</groupId>
- <artifactId>camel-health</artifactId>
- </dependency>
Review Comment:
It's a dup. It's already defined above in the pom.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] oscerd commented on a diff in pull request #8756: Fix build problems
Posted by GitBox <gi...@apache.org>.
oscerd commented on code in PR #8756:
URL: https://github.com/apache/camel/pull/8756#discussion_r1028841351
##########
components/camel-aws/camel-aws2-cw/pom.xml:
##########
@@ -80,9 +80,5 @@
<type>test-jar</type>
<scope>test</scope>
</dependency>
- <dependency>
- <groupId>org.apache.camel</groupId>
- <artifactId>camel-health</artifactId>
- </dependency>
Review Comment:
Well spotted. I shouldn't do review from the bed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #8756: Fix build problems
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8756:
URL: https://github.com/apache/camel/pull/8756#issuecomment-1323079567
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:warning: Please note that the changes on this PR may be **tested automatically**.
If necessary Apache Camel Committers may access logs and test results in the job summaries!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #8756: Fix build problems
Posted by GitBox <gi...@apache.org>.
davsclaus commented on PR #8756:
URL: https://github.com/apache/camel/pull/8756#issuecomment-1323109433
is there anything to fix as well in camel-spring-boot or camel-karaf ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #8756: Fix build problems
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8756:
URL: https://github.com/apache/camel/pull/8756#issuecomment-1323141971
### Components tested:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 2 | 2 | 0 | 2 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org