[jira] [Commented] (THRIFT-2145) Rack and Thin are not just development dependencies

["Matt Gillooly (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13831643#comment-13831643 ] 

Matt Gillooly commented on THRIFT-2145:
---------------------------------------

+1 Nick and Andrew.

I've got a gem which requires thrift.  We had added rack and thin as dependencies of that gem to get around this issue.  We now wish to use that gem in a JRuby environment, where thin is not available, so I'm forced to either fork the thrift gem or add a dummy thin.rb to my gem.  Neither of these seem reasonable, when there is a simple fix in the attached patch above.

> Rack and Thin are not just development dependencies
> ---------------------------------------------------
>
>                 Key: THRIFT-2145
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2145
>             Project: Thrift
>          Issue Type: Bug
>          Components: Ruby - Library
>    Affects Versions: 0.9.1
>         Environment: Mac OS X and Linux, Ruby v1.9.3
>            Reporter: Keith Barrette
>            Assignee: Jake Farrell
>         Attachments: 0001-Require-thin-server-in-spec-that-uses-it.patch, thrift-0.9.1-rack-thin-dependency.patch
>
>
> The rack and thin gems should be specified as full dependencies, not just development dependencies.
> This is causing runtime errors when requiring thrift.



--
This message was sent by Atlassian JIRA
(v6.1#6144)