[GitHub] [carbondata] jackylk commented on a change in pull request #3731: [CARBONDATA-3786] presto carbon reader should use tablePath from hive catalog

[GitBox <gi...@apache.org>]

jackylk commented on a change in pull request #3731:
URL: https://github.com/apache/carbondata/pull/3731#discussion_r418481378



##########
File path: integration/presto/src/main/prestodb/org/apache/carbondata/presto/CarbondataSplitManager.java
##########
@@ -109,8 +109,14 @@ public ConnectorSplitSource getSplits(ConnectorTransactionHandle transactionHand
     if (!table.getStorage().getStorageFormat().getInputFormat().contains("carbon")) {
       return super.getSplits(transactionHandle, session, layoutHandle, splitSchedulingStrategy);
     }
-    String location = table.getStorage().getLocation();
-
+    String location;

Review comment:
       assign with table.getStorage().getSerdeParameters().get("tablePath") first and then update it if null




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org