You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org> on 2024/09/16 23:06:07 UTC

[kudu-CR](branch-1.17.x) [cmake] work around of Gradle-related issues (take 2)

Abhishek Chennaka has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21810


Change subject: [cmake] work around of Gradle-related issues (take 2)
......................................................................

[cmake] work around of Gradle-related issues (take 2)

This is a follow-up to a1cc227df5d5dc7586d3971135643320682b2709.

Change-Id: I5875d7fff1304be1da93c9f4f9b6fb28bda3bdbb
Reviewed-on: http://gerrit.cloudera.org:8080/21669
Tested-by: Kudu Jenkins
Reviewed-by: Zoltan Chovan <zc...@cloudera.com>
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
(cherry picked from commit ff69c2e312e5385037db214f50605979fd26a9f5)
---
M CMakeLists.txt
M src/kudu/hms/CMakeLists.txt
2 files changed, 24 insertions(+), 16 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/10/21810/1
-- 
To view, visit http://gerrit.cloudera.org:8080/21810
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5875d7fff1304be1da93c9f4f9b6fb28bda3bdbb
Gerrit-Change-Number: 21810
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>

[kudu-CR](branch-1.17.x) [cmake] work around of Gradle-related issues (take 2)

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21810 )

Change subject: [cmake] work around of Gradle-related issues (take 2)
......................................................................


Patch Set 1: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/21810
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I5875d7fff1304be1da93c9f4f9b6fb28bda3bdbb
Gerrit-Change-Number: 21810
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 17 Sep 2024 16:59:40 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.17.x) [cmake] work around of Gradle-related issues (take 2)

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21810 )

Change subject: [cmake] work around of Gradle-related issues (take 2)
......................................................................

[cmake] work around of Gradle-related issues (take 2)

This is a follow-up to a1cc227df5d5dc7586d3971135643320682b2709.

Change-Id: I5875d7fff1304be1da93c9f4f9b6fb28bda3bdbb
Reviewed-on: http://gerrit.cloudera.org:8080/21669
Tested-by: Kudu Jenkins
Reviewed-by: Zoltan Chovan <zc...@cloudera.com>
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
(cherry picked from commit ff69c2e312e5385037db214f50605979fd26a9f5)
Reviewed-on: http://gerrit.cloudera.org:8080/21810
Reviewed-by: Alexey Serbin <al...@apache.org>
Tested-by: Abhishek Chennaka <ac...@cloudera.com>
---
M CMakeLists.txt
M src/kudu/hms/CMakeLists.txt
2 files changed, 24 insertions(+), 16 deletions(-)

Approvals:
  Alexey Serbin: Looks good to me, approved
  Abhishek Chennaka: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/21810
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I5875d7fff1304be1da93c9f4f9b6fb28bda3bdbb
Gerrit-Change-Number: 21810
Gerrit-PatchSet: 2
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR](branch-1.17.x) [cmake] work around of Gradle-related issues (take 2)

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has removed a vote on this change.

Change subject: [cmake] work around of Gradle-related issues (take 2)
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/21810
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I5875d7fff1304be1da93c9f4f9b6fb28bda3bdbb
Gerrit-Change-Number: 21810
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR](branch-1.17.x) [cmake] work around of Gradle-related issues (take 2)

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21810 )

Change subject: [cmake] work around of Gradle-related issues (take 2)
......................................................................


Patch Set 1:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/518/


-- 
To view, visit http://gerrit.cloudera.org:8080/21810
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I5875d7fff1304be1da93c9f4f9b6fb28bda3bdbb
Gerrit-Change-Number: 21810
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 16 Sep 2024 23:06:15 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.17.x) [cmake] work around of Gradle-related issues (take 2)

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21810 )

Change subject: [cmake] work around of Gradle-related issues (take 2)
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/21810
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I5875d7fff1304be1da93c9f4f9b6fb28bda3bdbb
Gerrit-Change-Number: 21810
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 16 Sep 2024 23:43:16 +0000
Gerrit-HasComments: No

[kudu-CR](branch-1.17.x) [cmake] work around of Gradle-related issues (take 2)

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21810 )

Change subject: [cmake] work around of Gradle-related issues (take 2)
......................................................................


Patch Set 1: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/518/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/21810
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I5875d7fff1304be1da93c9f4f9b6fb28bda3bdbb
Gerrit-Change-Number: 21810
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 17 Sep 2024 01:12:17 +0000
Gerrit-HasComments: No