[jira] [Resolved] (OAK-3468) Replace BackgroundThread with Scheduler

["Francesco Mari (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OAK-3468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Francesco Mari resolved OAK-3468.
---------------------------------
       Resolution: Fixed
    Fix Version/s: Segment Tar 0.0.4

The change at r1750636 replaces the {{BackgroundThread}} with two classes - {{PeriodicOperation}} and {{TriggeredOperation}}. Both of these classes represent a background operation running on a separate thread, but they differ in the way the execution of the operation is triggered.

There is a regression in functionality, though. {{BackgroundThread}} maintained some simple statistics about the execution time in the name of the thread itself, while the current implementation doesn't maintain and expose these information anymore. I decided to go with this changes anyway because

# the thread name is a very bad place to store these information, and unlikely to be looked up to,
# a richer amount of information is logged in more accessible ways,
# and this missing functionality has been traded with a more mature and stable implementation.

> Replace BackgroundThread with Scheduler
> ---------------------------------------
>
>                 Key: OAK-3468
>                 URL: https://issues.apache.org/jira/browse/OAK-3468
>             Project: Jackrabbit Oak
>          Issue Type: Technical task
>          Components: segment-tar
>            Reporter: Michael Dürig
>            Assignee: Francesco Mari
>              Labels: technical_debt
>             Fix For: Segment Tar 0.0.4
>
>
> I think we should replace the background thread with some kind of a scheduler. The goal would be to decouple threading from scheduling. IMO threads should not be managed by the application but by the container. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)