You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/01/11 04:56:29 UTC
[GitHub] [tvm] luyaor opened a new pull request #7242: [Relay][Frontend][Onnx] Set default value of p in LpPool as 2
luyaor opened a new pull request #7242:
URL: https://github.com/apache/tvm/pull/7242
See https://github.com/apache/tvm/issues/7241
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] luyaor commented on pull request #7242: [Relay][Frontend][Onnx] Set default value of p in LpPool as 2
Posted by GitBox <gi...@apache.org>.
luyaor commented on pull request #7242:
URL: https://github.com/apache/tvm/pull/7242#issuecomment-788541151
Hi @jwfromm , I added a testcase.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen edited a comment on pull request #7242: [Relay][Frontend][Onnx] Set default value of p in LpPool as 2
Posted by GitBox <gi...@apache.org>.
tqchen edited a comment on pull request #7242:
URL: https://github.com/apache/tvm/pull/7242#issuecomment-792789679
run `tests/lint/git-black.sh -i upstream/main` to format the python code so we can pass the CI lint error
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] luyaor commented on pull request #7242: [Relay][Frontend][Onnx] Set default value of p in LpPool as 2
Posted by GitBox <gi...@apache.org>.
luyaor commented on pull request #7242:
URL: https://github.com/apache/tvm/pull/7242#issuecomment-792454554
Hi @jwfromm , what do you mean that `format the test file`? I am a little bit confused.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] jwfromm commented on pull request #7242: [Relay][Frontend][Onnx] Set default value of p in LpPool as 2
Posted by GitBox <gi...@apache.org>.
jwfromm commented on pull request #7242:
URL: https://github.com/apache/tvm/pull/7242#issuecomment-758340015
Can you add a test that would trigger the error? Once that's included in this PR it should be good to go. Thanks for identifying and fixing this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] vinx13 closed pull request #7242: [Relay][Frontend][Onnx] Set default value of p in LpPool as 2
Posted by GitBox <gi...@apache.org>.
vinx13 closed pull request #7242:
URL: https://github.com/apache/tvm/pull/7242
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen commented on pull request #7242: [Relay][Frontend][Onnx] Set default value of p in LpPool as 2
Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #7242:
URL: https://github.com/apache/tvm/pull/7242#issuecomment-780185536
ping @jwfromm @luyaor , it would be great to follow up on this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] luyaor commented on pull request #7242: [Relay][Frontend][Onnx] Set default value of p in LpPool as 2
Posted by GitBox <gi...@apache.org>.
luyaor commented on pull request #7242:
URL: https://github.com/apache/tvm/pull/7242#issuecomment-757624223
@jwfromm
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] jwfromm commented on pull request #7242: [Relay][Frontend][Onnx] Set default value of p in LpPool as 2
Posted by GitBox <gi...@apache.org>.
jwfromm commented on pull request #7242:
URL: https://github.com/apache/tvm/pull/7242#issuecomment-789142274
Looks like you just need to format the test file and we can merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen commented on pull request #7242: [Relay][Frontend][Onnx] Set default value of p in LpPool as 2
Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #7242:
URL: https://github.com/apache/tvm/pull/7242#issuecomment-792789679
run `tests/lint/git-black.sh -i upstream/main`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org