You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Pranav Saxena <pr...@citrix.com> on 2013/05/30 15:50:27 UTC
[MERGE] UI for Explicit-Dedication of
Resources(zone/pod/cluster/host)
Hi all,
I would like to merge UI support for Explicit Dedication of Resources( Zone/Pod/Cluster/Host) . The entire development has been done on my feature branch - [ asf/UI-explicitDedication ]
-Includes the following UI functionality -
1) Zone dedication at the time of its creation through the Zone Wizard ( dedicate zone either to a domain or a domain and an account)
2) Individual dedication of each resource( zone/pod/cluster/host) to any domain/sub-domain/account after a zone has been created
3) Release dedication action items for reach resource( zone/pod/cluster/host) from any domain/sub-domain/account once a resource is dedicated which toggle between the dedicated action items if a resource is dedicated or not.
The current behavior of creating a private zone was based on unchecking the "ispublic" checkbox and then choosing a domain but now that has been removed and a dedicate checkbox has been introduced which will be unchecked by default which means that a user will end up creating a public zone . If he checks it , he needs to dedicate it to a domain/account .
-UI work done by: Pranav Saxena <pr...@citrix.com>>
FS: Please see FS for each subtask outlined on JIRA page - https://issues.apache.org/jira/browse/CLOUDSTACK-681 https://cwiki.apache.org/CLOUDSTACK/dedicated-resources-private-zone-pod-cluster-host-functional-spec.html
Branch: ui-vpc-redesign
Unit tests: N/A (UI only)
RAT report ran successfully
Backend API support already available in asf/master
Thanks,
Pranav
RE: [MERGE] UI for Explicit-Dedication of
Resources(zone/pod/cluster/host)
Posted by Pranav Saxena <pr...@citrix.com>.
Sure Chip , no problems. I'll go ahead and merge my branch tomorrow in that case and take up localization tasks thereafter. Thanks for reviewing the code and your feedback.
Regards,
Pranav
-----Original Message-----
From: Chip Childers [mailto:chip.childers@sungard.com]
Sent: Friday, May 31, 2013 1:23 AM
To: dev@cloudstack.apache.org
Cc: Sonny Chhen; Brian Federle; Jessica Wang; Animesh Chaturvedi
Subject: Re: [MERGE] UI for Explicit-Dedication of Resources(zone/pod/cluster/host)
On Thu, May 30, 2013 at 05:38:18PM +0000, Pranav Saxena wrote:
> So currently they are not localized. Usually we localize all the labels , dialog messages whenever a feature is into master and I had planned to do the same with this one as well . Since that doesn't affect the feature functionality , I thought of merging the feature before so that people(QA ) could pick it up and start testing it (which gives them more time testing a feature) and meanwhile I could localize the various entities simultaneously.
>
> If you are ok with it , I shall merge the feature or if you want the strings to be localized first I can do that as well .
I'm good with your approach. I was only asking out of interest.
>
> Thanks,
> Pranav
>
> -----Original Message-----
> From: Chip Childers [mailto:chip.childers@sungard.com]
> Sent: Thursday, May 30, 2013 10:54 PM
> To: Pranav Saxena
> Cc: dev@cloudstack.apache.org; Sonny Chhen; Brian Federle; Jessica Wang; Animesh Chaturvedi
> Subject: Re: [MERGE] UI for Explicit-Dedication of Resources(zone/pod/cluster/host)
>
> On Thu, May 30, 2013 at 04:29:36PM +0000, Pranav Saxena wrote:
> > Thanks Chip for reminding me of that . I have rebased my branch off latest master now and there are no conflicts . Please go ahead and have a look at the diff .
> > Please let me know in case there are any concerns.
> >
> > Thanks,
> > Pranav
>
> Thanks!
>
> I have a question, but +1 from me.
>
> Question:
>
> Generally, I see lots of static strings that assume en-US in the patch (which seems to follow the existing patterns). How are those strings localized? Or are they not?
>
> This is my first time reviewing UI code in depth, hence the question (I wanted to see how a feature like this was pulled together... it's a good model!).
>
> Examples in:
> ui/scripts/docs.js
> ui/scripts/system.js
>
> These include labels, error messages, dialog messages, etc...
>
> -chip
>
Re: [MERGE] UI for Explicit-Dedication of
Resources(zone/pod/cluster/host)
Posted by Chip Childers <ch...@sungard.com>.
On Thu, May 30, 2013 at 05:38:18PM +0000, Pranav Saxena wrote:
> So currently they are not localized. Usually we localize all the labels , dialog messages whenever a feature is into master and I had planned to do the same with this one as well . Since that doesn't affect the feature functionality , I thought of merging the feature before so that people(QA ) could pick it up and start testing it (which gives them more time testing a feature) and meanwhile I could localize the various entities simultaneously.
>
> If you are ok with it , I shall merge the feature or if you want the strings to be localized first I can do that as well .
I'm good with your approach. I was only asking out of interest.
>
> Thanks,
> Pranav
>
> -----Original Message-----
> From: Chip Childers [mailto:chip.childers@sungard.com]
> Sent: Thursday, May 30, 2013 10:54 PM
> To: Pranav Saxena
> Cc: dev@cloudstack.apache.org; Sonny Chhen; Brian Federle; Jessica Wang; Animesh Chaturvedi
> Subject: Re: [MERGE] UI for Explicit-Dedication of Resources(zone/pod/cluster/host)
>
> On Thu, May 30, 2013 at 04:29:36PM +0000, Pranav Saxena wrote:
> > Thanks Chip for reminding me of that . I have rebased my branch off latest master now and there are no conflicts . Please go ahead and have a look at the diff .
> > Please let me know in case there are any concerns.
> >
> > Thanks,
> > Pranav
>
> Thanks!
>
> I have a question, but +1 from me.
>
> Question:
>
> Generally, I see lots of static strings that assume en-US in the patch (which seems to follow the existing patterns). How are those strings localized? Or are they not?
>
> This is my first time reviewing UI code in depth, hence the question (I wanted to see how a feature like this was pulled together... it's a good model!).
>
> Examples in:
> ui/scripts/docs.js
> ui/scripts/system.js
>
> These include labels, error messages, dialog messages, etc...
>
> -chip
>
RE: [MERGE] UI for Explicit-Dedication of
Resources(zone/pod/cluster/host)
Posted by Pranav Saxena <pr...@citrix.com>.
So currently they are not localized. Usually we localize all the labels , dialog messages whenever a feature is into master and I had planned to do the same with this one as well . Since that doesn't affect the feature functionality , I thought of merging the feature before so that people(QA ) could pick it up and start testing it (which gives them more time testing a feature) and meanwhile I could localize the various entities simultaneously.
If you are ok with it , I shall merge the feature or if you want the strings to be localized first I can do that as well .
Thanks,
Pranav
-----Original Message-----
From: Chip Childers [mailto:chip.childers@sungard.com]
Sent: Thursday, May 30, 2013 10:54 PM
To: Pranav Saxena
Cc: dev@cloudstack.apache.org; Sonny Chhen; Brian Federle; Jessica Wang; Animesh Chaturvedi
Subject: Re: [MERGE] UI for Explicit-Dedication of Resources(zone/pod/cluster/host)
On Thu, May 30, 2013 at 04:29:36PM +0000, Pranav Saxena wrote:
> Thanks Chip for reminding me of that . I have rebased my branch off latest master now and there are no conflicts . Please go ahead and have a look at the diff .
> Please let me know in case there are any concerns.
>
> Thanks,
> Pranav
Thanks!
I have a question, but +1 from me.
Question:
Generally, I see lots of static strings that assume en-US in the patch (which seems to follow the existing patterns). How are those strings localized? Or are they not?
This is my first time reviewing UI code in depth, hence the question (I wanted to see how a feature like this was pulled together... it's a good model!).
Examples in:
ui/scripts/docs.js
ui/scripts/system.js
These include labels, error messages, dialog messages, etc...
-chip
Re: [MERGE] UI for Explicit-Dedication of
Resources(zone/pod/cluster/host)
Posted by Chip Childers <ch...@sungard.com>.
On Thu, May 30, 2013 at 04:29:36PM +0000, Pranav Saxena wrote:
> Thanks Chip for reminding me of that . I have rebased my branch off latest master now and there are no conflicts . Please go ahead and have a look at the diff .
> Please let me know in case there are any concerns.
>
> Thanks,
> Pranav
Thanks!
I have a question, but +1 from me.
Question:
Generally, I see lots of static strings that assume en-US in the patch
(which seems to follow the existing patterns). How are those strings
localized? Or are they not?
This is my first time reviewing UI code in depth, hence the question
(I wanted to see how a feature like this was pulled together... it's a good model!).
Examples in:
ui/scripts/docs.js
ui/scripts/system.js
These include labels, error messages, dialog messages, etc...
-chip
RE: [MERGE] UI for Explicit-Dedication of
Resources(zone/pod/cluster/host)
Posted by Pranav Saxena <pr...@citrix.com>.
Thanks Chip for reminding me of that . I have rebased my branch off latest master now and there are no conflicts . Please go ahead and have a look at the diff .
Please let me know in case there are any concerns.
Thanks,
Pranav
-----Original Message-----
From: Chip Childers [mailto:chip.childers@sungard.com]
Sent: Thursday, May 30, 2013 9:26 PM
To: dev@cloudstack.apache.org
Cc: Sonny Chhen; Brian Federle; Jessica Wang; Animesh Chaturvedi
Subject: Re: [MERGE] UI for Explicit-Dedication of Resources(zone/pod/cluster/host)
On Thu, May 30, 2013 at 01:50:27PM +0000, Pranav Saxena wrote:
> Hi all,
>
> I would like to merge UI support for Explicit Dedication of Resources(
> Zone/Pod/Cluster/Host) . The entire development has been done on my
> feature branch - [ asf/UI-explicitDedication ]
>
> -Includes the following UI functionality -
> 1) Zone dedication at the time of its creation through the Zone Wizard
> ( dedicate zone either to a domain or a domain and an account)
> 2) Individual dedication of each resource( zone/pod/cluster/host) to
> any domain/sub-domain/account after a zone has been created
> 3) Release dedication action items for reach resource( zone/pod/cluster/host) from any domain/sub-domain/account once a resource is dedicated which toggle between the dedicated action items if a resource is dedicated or not.
>
> The current behavior of creating a private zone was based on unchecking the "ispublic" checkbox and then choosing a domain but now that has been removed and a dedicate checkbox has been introduced which will be unchecked by default which means that a user will end up creating a public zone . If he checks it , he needs to dedicate it to a domain/account .
>
> -UI work done by: Pranav Saxena
> <pr...@citrix.com>>
>
> FS: Please see FS for each subtask outlined on JIRA page -
> https://issues.apache.org/jira/browse/CLOUDSTACK-681
> https://cwiki.apache.org/CLOUDSTACK/dedicated-resources-private-zone-p
> od-cluster-host-functional-spec.html
> Branch: ui-vpc-redesign
> Unit tests: N/A (UI only)
> RAT report ran successfully
> Backend API support already available in asf/master
>
> Thanks,
> Pranav
>
I ran:
git fetch origin
git checkout master
git diff origin/UI-explicitDedication...master
I think your branch is behind master quite a bit. Can you please pull the latest from master and then let us know when done so it can be a clean diff for review?
Thanks!
Re: [MERGE] UI for Explicit-Dedication of
Resources(zone/pod/cluster/host)
Posted by Chip Childers <ch...@sungard.com>.
On Thu, May 30, 2013 at 01:50:27PM +0000, Pranav Saxena wrote:
> Hi all,
>
> I would like to merge UI support for Explicit Dedication of Resources( Zone/Pod/Cluster/Host) . The entire development has been done on my feature branch - [ asf/UI-explicitDedication ]
>
> -Includes the following UI functionality -
> 1) Zone dedication at the time of its creation through the Zone Wizard ( dedicate zone either to a domain or a domain and an account)
> 2) Individual dedication of each resource( zone/pod/cluster/host) to any domain/sub-domain/account after a zone has been created
> 3) Release dedication action items for reach resource( zone/pod/cluster/host) from any domain/sub-domain/account once a resource is dedicated which toggle between the dedicated action items if a resource is dedicated or not.
>
> The current behavior of creating a private zone was based on unchecking the "ispublic" checkbox and then choosing a domain but now that has been removed and a dedicate checkbox has been introduced which will be unchecked by default which means that a user will end up creating a public zone . If he checks it , he needs to dedicate it to a domain/account .
>
> -UI work done by: Pranav Saxena <pr...@citrix.com>>
>
> FS: Please see FS for each subtask outlined on JIRA page - https://issues.apache.org/jira/browse/CLOUDSTACK-681 https://cwiki.apache.org/CLOUDSTACK/dedicated-resources-private-zone-pod-cluster-host-functional-spec.html
> Branch: ui-vpc-redesign
> Unit tests: N/A (UI only)
> RAT report ran successfully
> Backend API support already available in asf/master
>
> Thanks,
> Pranav
>
I ran:
git fetch origin
git checkout master
git diff origin/UI-explicitDedication...master
I think your branch is behind master quite a bit. Can you please pull the latest
from master and then let us know when done so it can be a clean diff for
review?
Thanks!