[GitHub] [incubator-uniffle] advancedxy commented on a diff in pull request #491: [ISSUE-479] [operator] refine operator's build system

["advancedxy (via GitHub)" <gi...@apache.org>]

advancedxy commented on code in PR #491:
URL: https://github.com/apache/incubator-uniffle/pull/491#discussion_r1089890768


##########
deploy/kubernetes/operator/hack/Dockerfile:
##########
@@ -35,12 +35,9 @@ COPY pkg/ pkg/
 # Build
 RUN CGO_ENABLED=0 GOOS=linux GOARCH=amd64 GO111MODULE=on go build -a -o ${MODULE} cmd/${MODULE}/main.go
 
-# Use distroless as minimal base image to package the manager binary
-# Refer to https://github.com/GoogleContainerTools/distroless for more details
-FROM alpine
-RUN apk add --update curl && \
-    rm -rf /var/cache/apk/*
+FROM debian:11.6-slim
+ARG MODULE

Review Comment:
   No. ARG should be declared multiple times per build stage. See https://stackoverflow.com/a/53682110



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org