[jira] [Commented] (HIVE-16573) In-place update for HoS can't be disabled

["Bing Li (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-16573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16036565#comment-16036565 ] 

Bing Li commented on HIVE-16573:
--------------------------------

Hi, [~ruili] and [~anishek]
Seems that we can't import class SessionState into InPlaceUpdate.java, it will cause module cycles error during compiling, which is hive-common->hive-exec->hive-common.

I changed it as below:
    String engine = HiveConf.getVar(conf, HiveConf.ConfVars.HIVE_EXECUTION_ENGINE);
    boolean inPlaceUpdates = false;

    if (engine.equals("tez"))
      inPlaceUpdates = HiveConf.getBoolVar(conf, HiveConf.ConfVars.TEZ_EXEC_INPLACE_PROGRESS);

    if (engine.equals("spark"))
      inPlaceUpdates = HiveConf.getBoolVar(conf, HiveConf.ConfVars.SPARK_EXEC_INPLACE_PROGRESS);

Do you think is ok?


> In-place update for HoS can't be disabled
> -----------------------------------------
>
>                 Key: HIVE-16573
>                 URL: https://issues.apache.org/jira/browse/HIVE-16573
>             Project: Hive
>          Issue Type: Bug
>          Components: Spark
>            Reporter: Rui Li
>            Assignee: Bing Li
>            Priority: Minor
>
> {{hive.spark.exec.inplace.progress}} has no effect



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)