[GitHub] [spark] shahidki31 commented on a change in pull request #24171: [SPARK-27204]SHS: Background caching for completed applications, when the disk store enabled

[GitBox <gi...@apache.org>]

shahidki31 commented on a change in pull request #24171: [SPARK-27204]SHS: Background caching for completed applications, when the disk store enabled
URL: https://github.com/apache/spark/pull/24171#discussion_r270541433
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala
 ##########
 @@ -122,6 +123,23 @@ private[history] class FsHistoryProvider(conf: SparkConf, clock: Clock)
   // and applications between check task and clean task.
   private val pool = ThreadUtils.newDaemonSingleThreadScheduledExecutor("spark-history-task-%d")
 
+  private val diskStoreCacheEnabled = conf.get(LOCAL_STORE_DIR).nonEmpty &&
+    conf.get(DISK_BACKGROUND_CACHE_ENABLED)
+
+  // Create a threadpool for background disk caching, if enabled,
+  // "spark.history.fs.disk.backgroundCache.enabled"
+  private val replayPool = if (diskStoreCacheEnabled) {
 
 Review comment:
   Thanks @felixcheung. Yeah. I would like to know if the approach is okay, code wise still need some clean up. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org