[GitHub] liupc edited a comment on issue #23711: [SPARK-26795][SHUFFLE]Retry remote fileSegmentManagedBuffer when creating inputStream failed during shuffle read phase#SPARK-26795

[GitBox <gi...@apache.org>]

liupc edited a comment on issue #23711: [SPARK-26795][SHUFFLE]Retry remote fileSegmentManagedBuffer when creating inputStream failed during shuffle read phase#SPARK-26795
URL: https://github.com/apache/spark/pull/23711#issuecomment-459734196
 
 
   +1 for @squito 
   @hustfeiwang I don't think this PR does really help much, because the fetch already has a retry logic(see RetryingBlockFetcher). If what you mean probably a disk error, rewrite does not help much because they may hash to the same parent directory. 
   Most of all,  it's very likely an earlier writing failure would happen which directly causes FetchFailedException.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org