You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sdap.apache.org by GitBox <gi...@apache.org> on 2021/10/29 18:41:34 UTC

[GitHub] [incubator-sdap-nexus] skorper commented on a change in pull request #142: SDAP-355: Update matchup parameter and output to use primary and secondary

skorper commented on a change in pull request #142:
URL: https://github.com/apache/incubator-sdap-nexus/pull/142#discussion_r739458964



##########
File path: analysis/webservice/apidocs/openapi.yml
##########
@@ -671,12 +673,19 @@ components:
           type: string
         source:
           type: string
-        analysed_sst:
-          type: number # TODO Fix this
         matches:
           type: array
           items:
-            $ref: '#/components/schemas/DomsPoint'
+            $ref: '#/components/schemas/DomsPointSecondary'

Review comment:
       Thanks @joshgarde! I believe I've addressed the circular reference by moving the `matches` property from `DomsPointBase` to `DomsPointPrimary`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sdap.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org