[GitHub] [tomcat] prankkelkar commented on a change in pull request #276: Add s390x Travis support

[GitBox <gi...@apache.org>]

prankkelkar commented on a change in pull request #276:
URL: https://github.com/apache/tomcat/pull/276#discussion_r412705684



##########
File path: .travis.yml
##########
@@ -32,14 +36,7 @@ addons:
         - libtool-bin
 
 install:
-    - ARCH=`uname -p`
-    - echo $ARCH
-    - JDK_X64="https://github.com/AdoptOpenJDK/openjdk8-binaries/releases/download/jdk8u242-b08/OpenJDK8U-jdk_x64_linux_hotspot_8u242b08.tar.gz"
-    - JDK_ARM64="https://github.com/AdoptOpenJDK/openjdk8-binaries/releases/download/jdk8u232-b09/OpenJDK8U-jdk_aarch64_linux_hotspot_8u232b09.tar.gz"
-    - if test "X$ARCH" = "Xaarch64"; then JDK_URL=$JDK_ARM64; else JDK_URL=$JDK_X64; fi
-    - wget -q $JDK_URL && tar xzf OpenJDK*.tar.gz
-    - mv jdk8* jdk
-    - export JAVA_HOME=`pwd`/jdk

Review comment:
       I had shifted to use travis jdk to make things cleaner. Also since the version was exactly same i thought the steps were redundant. I will revert since you want keep it the way it is.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org