[GitHub] [storm] agresch commented on a change in pull request #3265: [STORM-2687] Add network proximity needs based executor sorting method

[GitBox <gi...@apache.org>]

agresch commented on a change in pull request #3265:
URL: https://github.com/apache/storm/pull/3265#discussion_r422191228



##########
File path: storm-client/src/jvm/org/apache/storm/Config.java
##########
@@ -312,6 +312,13 @@
     // the topology.
     public static final String TOPOLOGY_SCHEDULER_STRATEGY = "topology.scheduler.strategy";
 
+    /**
+     * When DefaultResourceAwareStrategy or GenericResourceAwareStrategy is used,
+     * it will arrange unassigned executors based a particular order.
+     * If this config is set to true, the arrangement will be made by network proximity needs.
+     */
+    public static final String TOPOLOGY_RAS_ORDER_EXECUTORS_BY_PROXIMITY_NEEDS = "topology.ras.order.executors.by.proximity.needs";

Review comment:
       I think this would be good to add to defaults.yaml so users will see the value for their topology in the ui.  It might be nice to have schedule somewhere in the name, I think users might remember/see it more likely then.  Possibly topology.schedule.executors.by.proximity.needs?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org