You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2014/05/07 23:41:23 UTC
Review Request 21175: Moved ReconcileTaskTest test to its own file.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21175/
-----------------------------------------------------------
Review request for mesos and Dominic Hamon.
Bugs: MESOS-1320
https://issues.apache.org/jira/browse/MESOS-1320
Repository: mesos-git
Description
-------
Just a move. No code changes.
Setting up for https://issues.apache.org/jira/browse/MESOS-1320
Diffs
-----
src/Makefile.am f461a1515e7bafac677f2d0bcdd499f57ba3f029
src/tests/master_tests.cpp 939a08d0ed25293d103728864c2b5e79f04a1b42
src/tests/reconciliation_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/21175/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 21175: Moved ReconcileTaskTest test to its own file.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21175/
-----------------------------------------------------------
(Updated May 12, 2014, 5:20 p.m.)
Review request for mesos and Dominic Hamon.
Changes
-------
rebased. NNFR.
Bugs: MESOS-1320
https://issues.apache.org/jira/browse/MESOS-1320
Repository: mesos-git
Description
-------
Just a move. No code changes.
Setting up for https://issues.apache.org/jira/browse/MESOS-1320
Diffs (updated)
-----
src/Makefile.am 812ad2cea4349727e92d0aa04fc8ce9b6c637af7
src/tests/master_tests.cpp 30ea7ffad4eb0ad011942d91cbf61284b031a80e
src/tests/reconciliation_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/21175/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 21175: Moved ReconcileTaskTest test to its own file.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21175/#review42546
-----------------------------------------------------------
Patch looks great!
Reviews applied: [21175]
All tests passed.
- Mesos ReviewBot
On May 8, 2014, 8:56 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21175/
> -----------------------------------------------------------
>
> (Updated May 8, 2014, 8:56 p.m.)
>
>
> Review request for mesos and Dominic Hamon.
>
>
> Bugs: MESOS-1320
> https://issues.apache.org/jira/browse/MESOS-1320
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Just a move. No code changes.
>
> Setting up for https://issues.apache.org/jira/browse/MESOS-1320
>
>
> Diffs
> -----
>
> src/Makefile.am f461a1515e7bafac677f2d0bcdd499f57ba3f029
> src/tests/master_tests.cpp 939a08d0ed25293d103728864c2b5e79f04a1b42
> src/tests/reconciliation_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/21175/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 21175: Moved ReconcileTaskTest test to its own file.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21175/
-----------------------------------------------------------
(Updated May 8, 2014, 8:56 p.m.)
Review request for mesos and Dominic Hamon.
Changes
-------
fixed the rebase. NNFR.
Bugs: MESOS-1320
https://issues.apache.org/jira/browse/MESOS-1320
Repository: mesos-git
Description
-------
Just a move. No code changes.
Setting up for https://issues.apache.org/jira/browse/MESOS-1320
Diffs (updated)
-----
src/Makefile.am f461a1515e7bafac677f2d0bcdd499f57ba3f029
src/tests/master_tests.cpp 939a08d0ed25293d103728864c2b5e79f04a1b42
src/tests/reconciliation_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/21175/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 21175: Moved ReconcileTaskTest test to its own file.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21175/
-----------------------------------------------------------
(Updated May 8, 2014, 8:09 p.m.)
Review request for mesos and Dominic Hamon.
Changes
-------
rebased. NNFR.
Bugs: MESOS-1320
https://issues.apache.org/jira/browse/MESOS-1320
Repository: mesos-git
Description
-------
Just a move. No code changes.
Setting up for https://issues.apache.org/jira/browse/MESOS-1320
Diffs (updated)
-----
src/Makefile.am f461a1515e7bafac677f2d0bcdd499f57ba3f029
src/master/master.hpp 0a350b0b402edb3ca648c91c920043f66c08fe0e
src/master/master.cpp 87ea77aa19e482a20f081061e81acc89582eacdd
src/tests/master_tests.cpp 939a08d0ed25293d103728864c2b5e79f04a1b42
src/tests/reconciliation_tests.cpp PRE-CREATION
src/tests/registrar_zookeeper_tests.cpp 376ac1ed6d62f977f4aa3d55007f225e5a534ce1
Diff: https://reviews.apache.org/r/21175/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 21175: Moved ReconcileTaskTest test to its own file.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21175/#review42536
-----------------------------------------------------------
Ship it!
Ship It!
- Dominic Hamon
On May 7, 2014, 2:41 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21175/
> -----------------------------------------------------------
>
> (Updated May 7, 2014, 2:41 p.m.)
>
>
> Review request for mesos and Dominic Hamon.
>
>
> Bugs: MESOS-1320
> https://issues.apache.org/jira/browse/MESOS-1320
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Just a move. No code changes.
>
> Setting up for https://issues.apache.org/jira/browse/MESOS-1320
>
>
> Diffs
> -----
>
> src/Makefile.am f461a1515e7bafac677f2d0bcdd499f57ba3f029
> src/tests/master_tests.cpp 939a08d0ed25293d103728864c2b5e79f04a1b42
> src/tests/reconciliation_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/21175/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>