[GitHub] [incubator-druid] leventov commented on a change in pull request #7350: Collect in List instead of Set

[GitBox <gi...@apache.org>]

leventov commented on a change in pull request #7350: Collect in List instead of Set
URL: https://github.com/apache/incubator-druid/pull/7350#discussion_r270585724
 
 

 ##########
 File path: server/src/main/java/org/apache/druid/server/http/MetadataResource.java
 ##########
 @@ -158,7 +158,7 @@ public Response getDatabaseSegments(
     if (datasources != null && !datasources.isEmpty()) {
       druidDataSources = druidDataSources.stream()
                                          .filter(src -> datasources.contains(src.getName()))
-                                         .collect(Collectors.toSet());
+                                         .collect(Collectors.toList());
 
 Review comment:
   @surekhasaharan please add a comment explaining that getDataSources() returns unique data sources, so expensive collection to Set is not required.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org