[GitHub] [hive] kgyrtkirk commented on a change in pull request #2732: HIVE-25625: Drop DummyCliDriver, TestCompareCliDriver and related code from tests

[GitBox <gi...@apache.org>]

kgyrtkirk commented on a change in pull request #2732:
URL: https://github.com/apache/hive/pull/2732#discussion_r732868243



##########
File path: testutils/ptest2/conf/deployed/master-mr2.properties
##########
@@ -84,7 +84,7 @@ ut.itests.hive-unit.skipBatching=TestAcidOnTezWithSplitUpdate TestAcidOnTez Test
 
 unitTests.module.itests.qtest=itests.qtest
 ut.itests.qtest.batchSize=9
-ut.itests.qtest.skipBatching=TestCompareCliDriver TestContribCliDriver TestContribNegativeCliDriver TestEncryptedHDFSCliDriver TestHBaseNegativeCliDriver TestPerfCliDriver TestParseNegativeDriver
+ut.itests.qtest.skipBatching=TestContribCliDriver TestContribNegativeCliDriver TestEncryptedHDFSCliDriver TestHBaseNegativeCliDriver TestPerfCliDriver TestParseNegativeDriver

Review comment:
       we don't really need to take care of this....in fact we may simply remove this `ptest` and `ptest2` directories as well...they are just dead weight (you may include the removal of them in the next cleanup ticket/or separate)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org