[GitHub] [ignite-3] sashapolo commented on a diff in pull request #1348: IGNITE-18155 Add learners to RaftGroupService#changePeersAsync

[GitBox <gi...@apache.org>]

sashapolo commented on code in PR #1348:
URL: https://github.com/apache/ignite-3/pull/1348#discussion_r1026547259


##########
modules/raft-client/src/main/java/org/apache/ignite/raft/client/service/RaftGroupService.java:
##########
@@ -150,25 +150,26 @@ public interface RaftGroupService {
      * @param peers Peers.
      * @return A future.
      */
-    CompletableFuture<Void> changePeers(List<Peer> peers);
+    CompletableFuture<Void> changePeers(Collection<Peer> peers);
 
     /**
-     * Changes peers of the replication group.
+     * Changes peers and learners of a replication group.
      *
      * <p>Asynchronous variant of the previous method.
-     * When the future completed, it just means, that changePeers process successfully started.
+     * When the future completed, it just means, that {@code changePeers} process has successfully started.
      *
-     * <p>The results of rebalance itself will be processed by the listener of raft reconfiguration event
+     * <p>The results of rebalance itself will be processed by the listener of Raft reconfiguration event
      * (from raft/server module).
      *
      * <p>This operation is executed on a group leader.
      *
-     * @param peers Peers.
+     * @param peers New peers.
+     * @param learners New learners.
      * @param term Current known leader term.
      *             If real raft group term will be different - changePeers will be skipped.
      * @return A future.
      */
-    CompletableFuture<Void> changePeersAsync(List<Peer> peers, long term);
+    CompletableFuture<Void> changePeersAsync(Collection<Peer> peers, Collection<Peer> learners, long term);

Review Comment:
   I understand, but `changePeersAndLearnersAsync` looks quite ugly to me



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org