[GitHub] [arrow] pitrou commented on pull request #11908: ARROW-15030: [C++] CSV writer test failures

[GitBox <gi...@apache.org>]

pitrou commented on pull request #11908:
URL: https://github.com/apache/arrow/pull/11908#issuecomment-989721253


   This doesn't fix the issue. Actually, you should be able to reproduce it by enabling `-DARROW_EXTRA_ERROR_CONTEXT=on` in the CMake config. It adds context lines to error messages which you can see in the failed comparison:
   ```
   [ RUN      ] MultiColumnWriteCSVTest/TestWriteCSV.TestWrite/13
   /home/antoine/arrow/dev/cpp/src/arrow/csv/writer_test.cc:246: Failure
   Expected equality of these values:
     ToCsvString(*record_batch, options)
       Which is: Invalid: CSV values may not contain structural characters if quoting style is "None". See RFC4180. Invalid value: foo
   /home/antoine/arrow/dev/cpp/src/arrow/csv/writer.cc:195  CheckStringHasNoStructuralChars(s)
   /home/antoine/arrow/dev/cpp/src/arrow/util/bit_block_counter.h:443  visit_not_null(position)
   /home/antoine/arrow/dev/cpp/src/arrow/csv/writer.cc:515  (*populator) ->PopulateColumns(reinterpret_cast<char*>(data_buffer_->mutable_data()), offsets_.data())
   /home/antoine/arrow/dev/cpp/src/arrow/csv/writer.cc:416  TranslateMinimalBatch(*slice)
   /home/antoine/arrow/dev/cpp/src/arrow/csv/writer.cc:547  writer->WriteRecordBatch(batch)
   /home/antoine/arrow/dev/cpp/src/arrow/csv/writer_test.cc:212  WriteCSV(data, options, out.get())
     GetParam().expected_status
       Which is: Invalid: CSV values may not contain structural characters if quoting style is "None". See RFC4180. Invalid value: foo
   [  FAILED  ] MultiColumnWriteCSVTest/TestWriteCSV.TestWrite/13, where GetParam() = WriterTestParams(0x55e9414b7230) (0 ms)
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org