You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spark.apache.org by Konstantin Boudnik <co...@apache.org> on 2013/09/05 04:16:03 UTC
Re: [spark] Change build and run instructions to use assemblies
(#857)
Matei,
sorry for the late checking... I've looked into your changes and all seems to
be in order.
Now I see that you are adding examples to the assembly, which I've pulled out
of the bigtop assembly initially. Do you think it is ok to add it back,
perhaps?
Cos
----- Forwarded message from Matei Zaharia <no...@github.com> -----
Date: Thu, 29 Aug 2013 21:51:49 -0700
From: Matei Zaharia <no...@github.com>
To: mesos/spark <sp...@noreply.github.com>
Cc: Cos <co...@apache.org>
Subject: Re: [spark] Change build and run instructions to use assemblies
(#857)
I'm going to merge this because a bunch of other things depend on it. If you try it on Maven and see any problems, let me know.
---
Reply to this email directly or view it on GitHub:
https://github.com/mesos/spark/pull/857#issuecomment-23540576
----- End forwarded message -----
Re: [spark] Change build and run instructions to use assemblies (#857)
Posted by Matei Zaharia <ma...@gmail.com>.
The examples do ship with their dependencies though AFAIK. I added a Maven shade plugin entry in the examples POM. Anyway, as long as you can run with that JAR, it means it works!
Matei
On Sep 4, 2013, at 9:22 PM, Konstantin Boudnik <co...@apache.org> wrote:
> Examples are built into a separate jar file, which isn't technically an
> assembly. But I think it is fine - I have added some code into Bigtop to
> simply reuse that jar without including it into an assembly.
>
> I guess that answers my question. Sorry, should've experiment first ;) Thanks
> Matei
>
> On Wed, Sep 04, 2013 at 09:17PM, Matei Zaharia wrote:
>> Cos, the examples are being built into a separate assembly. That should also
>> be true in the Maven assembly project as far as I can tell.
>>
>> Matei
>>
>> On Sep 4, 2013, at 7:16 PM, Konstantin Boudnik <co...@apache.org> wrote:
>>
>>> Matei,
>>>
>>> sorry for the late checking... I've looked into your changes and all seems to
>>> be in order.
>>>
>>> Now I see that you are adding examples to the assembly, which I've pulled out
>>> of the bigtop assembly initially. Do you think it is ok to add it back,
>>> perhaps?
>>>
>>> Cos
>>>
>>> ----- Forwarded message from Matei Zaharia <no...@github.com> -----
>>>
>>> Date: Thu, 29 Aug 2013 21:51:49 -0700
>>> From: Matei Zaharia <no...@github.com>
>>> To: mesos/spark <sp...@noreply.github.com>
>>> Cc: Cos <co...@apache.org>
>>> Subject: Re: [spark] Change build and run instructions to use assemblies
>>> (#857)
>>>
>>> I'm going to merge this because a bunch of other things depend on it. If you try it on Maven and see any problems, let me know.
>>>
>>> ---
>>> Reply to this email directly or view it on GitHub:
>>> https://github.com/mesos/spark/pull/857#issuecomment-23540576
>>>
>>> ----- End forwarded message -----
>>
Re: [spark] Change build and run instructions to use assemblies
(#857)
Posted by Konstantin Boudnik <co...@apache.org>.
Examples are built into a separate jar file, which isn't technically an
assembly. But I think it is fine - I have added some code into Bigtop to
simply reuse that jar without including it into an assembly.
I guess that answers my question. Sorry, should've experiment first ;) Thanks
Matei
On Wed, Sep 04, 2013 at 09:17PM, Matei Zaharia wrote:
> Cos, the examples are being built into a separate assembly. That should also
> be true in the Maven assembly project as far as I can tell.
>
> Matei
>
> On Sep 4, 2013, at 7:16 PM, Konstantin Boudnik <co...@apache.org> wrote:
>
> > Matei,
> >
> > sorry for the late checking... I've looked into your changes and all seems to
> > be in order.
> >
> > Now I see that you are adding examples to the assembly, which I've pulled out
> > of the bigtop assembly initially. Do you think it is ok to add it back,
> > perhaps?
> >
> > Cos
> >
> > ----- Forwarded message from Matei Zaharia <no...@github.com> -----
> >
> > Date: Thu, 29 Aug 2013 21:51:49 -0700
> > From: Matei Zaharia <no...@github.com>
> > To: mesos/spark <sp...@noreply.github.com>
> > Cc: Cos <co...@apache.org>
> > Subject: Re: [spark] Change build and run instructions to use assemblies
> > (#857)
> >
> > I'm going to merge this because a bunch of other things depend on it. If you try it on Maven and see any problems, let me know.
> >
> > ---
> > Reply to this email directly or view it on GitHub:
> > https://github.com/mesos/spark/pull/857#issuecomment-23540576
> >
> > ----- End forwarded message -----
>
Re: [spark] Change build and run instructions to use assemblies (#857)
Posted by Matei Zaharia <ma...@gmail.com>.
Cos, the examples are being built into a separate assembly. That should also be true in the Maven assembly project as far as I can tell.
Matei
On Sep 4, 2013, at 7:16 PM, Konstantin Boudnik <co...@apache.org> wrote:
> Matei,
>
> sorry for the late checking... I've looked into your changes and all seems to
> be in order.
>
> Now I see that you are adding examples to the assembly, which I've pulled out
> of the bigtop assembly initially. Do you think it is ok to add it back,
> perhaps?
>
> Cos
>
> ----- Forwarded message from Matei Zaharia <no...@github.com> -----
>
> Date: Thu, 29 Aug 2013 21:51:49 -0700
> From: Matei Zaharia <no...@github.com>
> To: mesos/spark <sp...@noreply.github.com>
> Cc: Cos <co...@apache.org>
> Subject: Re: [spark] Change build and run instructions to use assemblies
> (#857)
>
> I'm going to merge this because a bunch of other things depend on it. If you try it on Maven and see any problems, let me know.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/mesos/spark/pull/857#issuecomment-23540576
>
> ----- End forwarded message -----