You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Niall Pemberton (JIRA)" <ji...@codehaus.org> on 2010/03/10 03:07:55 UTC

[jira] Created: (DOXIA-384) Including a DTD reference in a element results in a SAXParseException

Including a DTD reference in a <source> element results in a SAXParseException
------------------------------------------------------------------------------

                 Key: DOXIA-384
                 URL: http://jira.codehaus.org/browse/DOXIA-384
             Project: Maven Doxia
          Issue Type: Bug
          Components: Core
    Affects Versions: 1.1.2
            Reporter: Niall Pemberton
         Attachments: Doxia-source-dtd-test.patch

Including a DTD in a <source> element should be ignored. But the PATTERN_DOCTYPE regular expresion used in the validate() method in AbstractXmlParser finds this and results in the XML being validated and causes a SAXParseException.

This is causing MSITE-464 reported against the maven-site-plugin.

We're also seeing a similar problem with the maven-pmd-plugin which may be related.

Attaching a test case which demonstrates this.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (DOXIA-384) Including a DTD reference in a element results in a SAXParseException

Posted by "Lukas Theussl (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/DOXIA-384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=213508#action_213508 ] 

Lukas Theussl commented on DOXIA-384:
-------------------------------------

We probably shouldn't use regexps at all. The DOCTYPE might also appear in a comment which will cause the same issue.

> Including a DTD reference in a <source> element results in a SAXParseException
> ------------------------------------------------------------------------------
>
>                 Key: DOXIA-384
>                 URL: http://jira.codehaus.org/browse/DOXIA-384
>             Project: Maven Doxia
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.1.2
>            Reporter: Niall Pemberton
>         Attachments: Doxia-source-dtd-test.patch
>
>
> Including a DTD in a <source> element should be ignored. But the PATTERN_DOCTYPE regular expresion used in the validate() method in AbstractXmlParser finds this and results in the XML being validated and causes a SAXParseException.
> This is causing MSITE-464 reported against the maven-site-plugin.
> We're also seeing a similar problem with the maven-pmd-plugin which may be related.
> Attaching a test case which demonstrates this.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (DOXIA-384) Including a DTD reference in a element results in a SAXParseException

Posted by "Lukas Theussl (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/DOXIA-384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lukas Theussl closed DOXIA-384.
-------------------------------

       Resolution: Fixed
    Fix Version/s: 1.1.3
         Assignee: Lukas Theussl

Should be fixed with DOXIA-390, I added your test case. Thanks!

> Including a DTD reference in a <source> element results in a SAXParseException
> ------------------------------------------------------------------------------
>
>                 Key: DOXIA-384
>                 URL: http://jira.codehaus.org/browse/DOXIA-384
>             Project: Maven Doxia
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.1.2
>            Reporter: Niall Pemberton
>            Assignee: Lukas Theussl
>             Fix For: 1.1.3
>
>         Attachments: Doxia-source-dtd-test.patch
>
>
> Including a DTD in a <source> element should be ignored. But the PATTERN_DOCTYPE regular expresion used in the validate() method in AbstractXmlParser finds this and results in the XML being validated and causes a SAXParseException.
> This is causing MSITE-464 reported against the maven-site-plugin.
> We're also seeing a similar problem with the maven-pmd-plugin which may be related.
> Attaching a test case which demonstrates this.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira