[GitHub] [spark] HyukjinKwon commented on a change in pull request #25464: [SPARK-28746][SQL] Add partitionby hint for sql queries

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #25464: [SPARK-28746][SQL] Add partitionby hint  for sql queries
URL: https://github.com/apache/spark/pull/25464#discussion_r338399146
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala
 ##########
 @@ -1307,7 +1308,16 @@ class Dataset[T] private[sql](
    */
   @scala.annotation.varargs
   def hint(name: String, parameters: Any*): Dataset[T] = withTypedPlan {
-    UnresolvedHint(name, parameters, logicalPlan)
+    if (ResolveHints.ResolveCoalesceHints.COALESCE_HINT_NAMES.contains(
 
 Review comment:
   Oh, I missed here. Yea, can we avoid to handle here?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org