You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/09/21 10:33:19 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #4566: drivers/syslog: Call up_puts in syslog_default_write instad up_putc

xiaoxiang781216 commented on pull request #4566:
URL: https://github.com/apache/incubator-nuttx/pull/4566#issuecomment-923851046


   > The commit [ca62341](https://github.com/apache/incubator-nuttx/commit/ca62341c931a2ee2536aea9d8f598f4e9f11f833) is incorrect and should be reverted. Nothing guarantees that the buffer is NUL-terminated. Nothing guarantees there won't be multiple NUL-terminated C-strings in the buffer. That is the reason for the length parameter in the syslog API. With this change, I started getting garbage at beginning of syslog lines:
   > 
   
   Sorry for inconvenience. Do you think the change in #4580 is good or add len parameter to up_puts?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org