[GitHub] [druid] rohangarg commented on a diff in pull request #12491: Add feature flag for sql planning of TimeBoundary queries

[GitBox <gi...@apache.org>]

rohangarg commented on code in PR #12491:
URL: https://github.com/apache/druid/pull/12491#discussion_r861576564


##########
processing/src/main/java/org/apache/druid/query/QueryContexts.java:
##########
@@ -70,6 +70,7 @@
   public static final String BY_SEGMENT_KEY = "bySegment";
   public static final String BROKER_SERVICE_NAME = "brokerService";
   public static final String IN_SUB_QUERY_THRESHOLD_KEY = "inSubQueryThreshold";
+  public static final String PLAN_TIME_BOUNDARY_SQL = "planTimeBoundarySql";

Review Comment:
   I had added `sql` to point that this config is only applicable to sql planning - the native query runs are independent of this flag.
   But seems right as you said that no other property also has this distinction - which upon rereading of the query context flags made me realise that there's no obvious way to in the name to know that whether a property is applicable only to SQL or both.
   There's `PlannerConfig` which has a `druid.sql.planner` prefix for all properties but that doesn't allow a direct query level override.
   Anyways, I will rename to `enableTimeBoundaryPlanning` to adhere to the current convention - thanks for the suggestion



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org