You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "jtulach (via GitHub)" <gi...@apache.org> on 2024/10/23 04:44:41 UTC
[PR] Robustness of the "Goto Type Dialog" [netbeans]
jtulach opened a new pull request, #7899:
URL: https://github.com/apache/netbeans/pull/7899
I started to see following exception when using the _"GoTo Type Dialog"_ and the dialog stop showing anything:
```
java.lang.UnsupportedOperationException
// deep stack skipped
at org.netbeans.modules.lsp.client.bindings.TypeProviderImpl.computeTypeNames(TypeProviderImpl.java:54)
at org.netbeans.modules.jumpto.type.GoToTypeAction$Worker.getTypeNames(GoToTypeAction.java:614)
at org.netbeans.modules.jumpto.type.GoToTypeAction$Worker.run(GoToTypeAction.java:522)
at org.openide.util.RequestProcessor$Task.run(RequestProcessor.java:1403)
at org.netbeans.modules.openide.util.GlobalLookup.execute(GlobalLookup.java:45)
at org.openide.util.lookup.Lookups.executeWith(Lookups.java:287)
at org.openide.util.RequestProcessor$Processor.run(RequestProcessor.java:2018)
```
It is not good when a single broken provider brakes everything. This PR catches exceptions from each provider, logs the exception coming from `TypeProvider.computeTypeNames` and goes on and querying the other providers. With this fix I see the exception in the log, but _"Goto Type Dialog" continues to work as expected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Robustness of the "Goto Type Dialog" [netbeans]
Posted by "ebarboni (via GitHub)" <gi...@apache.org>.
ebarboni commented on PR #7899:
URL: https://github.com/apache/netbeans/pull/7899#issuecomment-2434985989
it's fine, sync PR created.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Robustness of the "Goto Type Dialog" [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #7899:
URL: https://github.com/apache/netbeans/pull/7899#issuecomment-2432896904
tbh it is easy to overlook when the branch target is changed by a reviewer. My inspector gadget senses tell me that @jtulach probably saw the approval and simply merged, thinking that the PR will land in master.
but there was likely no harm done here, since the branch was pre-version bump, so the merge commit didn't blow up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Robustness of the "Goto Type Dialog" [netbeans]
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on PR #7899:
URL: https://github.com/apache/netbeans/pull/7899#issuecomment-2432783050
@jtulach please read NOTICE emails. Only @ebarboni or @MartinBalin should be merging to delivery.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Robustness of the "Goto Type Dialog" [netbeans]
Posted by "JaroslavTulach (via GitHub)" <gi...@apache.org>.
JaroslavTulach commented on PR #7899:
URL: https://github.com/apache/netbeans/pull/7899#issuecomment-2434616334
> @jtulach please read NOTICE emails. Only @ebarboni or @MartinBalin should be merging to delivery.
>
> https://cwiki.apache.org/confluence/display/NETBEANS/Pull+requests+for+delivery
Opps. I wanted to merge to `master`. Certainly I haven't changed the target branch!
> lahodaj changed the base branch from master to delivery
> easy to overlook when the branch target is changed by a reviewer.
I haven't noticed the change. I only checked [Jan's message](https://github.com/apache/netbeans/pull/7899#pullrequestreview-2388871282) - I wasn't expecting target branch change.
> likely no harm done here, since the branch was pre-version bump, so the merge commit didn't blow up.
Benefit of being behind the HEAD. Sorry for the ripples. @ebarboni or @MartinBalin feel free to keep or remove the change from `delivery`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Robustness of the "Goto Type Dialog" [netbeans]
Posted by "jtulach (via GitHub)" <gi...@apache.org>.
jtulach merged PR #7899:
URL: https://github.com/apache/netbeans/pull/7899
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists