[GitHub] spark pull request #13890: [SPARK-16189][SQL] Add ExistingRDD logical plan f...

[cloud-fan <gi...@git.apache.org>]

Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13890#discussion_r69674173
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/ExistingRDD.scala ---
    @@ -74,13 +74,71 @@ object RDDConversions {
       }
     }
     
    +private[sql] object ExistingRDD {
    +
    +  def apply[T: Encoder](rdd: RDD[T])(session: SparkSession): LogicalPlan = {
    +    val exisitingRdd = ExistingRDD(CatalystSerde.generateObjAttr[T], rdd)(session)
    +    CatalystSerde.serialize[T](exisitingRdd)
    +  }
    +}
    +
     /** Logical plan node for scanning data from an RDD. */
    +private[sql] case class ExistingRDD[T](
    +    outputObjAttr: Attribute,
    +    rdd: RDD[T])(session: SparkSession)
    --- End diff --
    
    why curry here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org