[jira] [Commented] (IGNITE-2920) CPP: IgniteError should be derived from std::runtime_error not from std::exception

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IGNITE-2920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15218436#comment-15218436 ] 

ASF GitHub Bot commented on IGNITE-2920:
----------------------------------------

GitHub user isapego opened a pull request:

    https://github.com/apache/ignite/pull/589

    IGNITE-2920: IgniteError now derives from std::runtime_error.

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/isapego/ignite ignite-2920

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ignite/pull/589.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #589
    
----
commit 2b1db571cea0cad26498939e927453a9092adad1
Author: isapego <is...@gridgain.com>
Date:   2016-03-30T17:46:04Z

    IGNITE-2920: IgniteError now derives from std::runtime_error.

----


> CPP: IgniteError should be derived from std::runtime_error not from std::exception
> ----------------------------------------------------------------------------------
>
>                 Key: IGNITE-2920
>                 URL: https://issues.apache.org/jira/browse/IGNITE-2920
>             Project: Ignite
>          Issue Type: Task
>          Components: platforms
>    Affects Versions: 1.5.0.final
>            Reporter: Igor Sapego
>            Assignee: Igor Sapego
>             Fix For: 1.6
>
>
> It seems like std::exception is not supposed to be used as a base class by user classes. It is suggested to use std::runtime_error instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)