You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@griffin.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2019/12/13 12:16:00 UTC
[jira] [Work logged] (GRIFFIN-310) Format scala code according to
scalastyle-config.xml and enable scala code style checking by default
[ https://issues.apache.org/jira/browse/GRIFFIN-310?focusedWorklogId=359331&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-359331 ]
ASF GitHub Bot logged work on GRIFFIN-310:
------------------------------------------
Author: ASF GitHub Bot
Created on: 13/Dec/19 12:15
Start Date: 13/Dec/19 12:15
Worklog Time Spent: 10m
Work Description: guoyuepeng commented on pull request #559: [GRIFFIN-310] Unified scala code style and enable scala code style checking by default
URL: https://github.com/apache/griffin/pull/559#discussion_r357618536
##########
File path: .travis.yml
##########
@@ -42,5 +42,5 @@ before_script:
script:
- export MAVEN_SKIP_RC=true
- export MAVEN_OPTS=" -Xmx1g -XX:ReservedCodeCacheSize=128m -Dorg.slf4j.simpleLogger.defaultLogLevel=warn -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn"
- - mvn -B clean test -Dlogging.level.org.springframework=WARN
+ - mvn -B clean scalastyle:check test -Dlogging.level.org.springframework=WARN
Review comment:
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 359331)
Remaining Estimate: 0h
Time Spent: 10m
> Format scala code according to scalastyle-config.xml and enable scala code style checking by default
> ----------------------------------------------------------------------------------------------------
>
> Key: GRIFFIN-310
> URL: https://issues.apache.org/jira/browse/GRIFFIN-310
> Project: Griffin
> Issue Type: Improvement
> Affects Versions: 0.6.0
> Reporter: Wan Kun
> Assignee: Wan Kun
> Priority: Major
> Fix For: 0.6.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Griffin has more and more contributors, so we need a unified code style and enable code style by default.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)