You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by su...@apache.org on 2019/02/28 08:12:59 UTC
[incubator-pinot] branch master updated: Replace deprecated
ZkClient APIs (#3894)
This is an automated email from the ASF dual-hosted git repository.
sunithabeeram pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/master by this push:
new caef8f6 Replace deprecated ZkClient APIs (#3894)
caef8f6 is described below
commit caef8f6941250f6723c0a6f847c66122876e1ee8
Author: Hunter Lee <na...@gmail.com>
AuthorDate: Thu Feb 28 00:12:54 2019 -0800
Replace deprecated ZkClient APIs (#3894)
The underlying interface for ZkClient in HelixManager has been changed to HelixZkClient. Using ZkClient directly is no longer recommended by Helix because it might cause ZkConnection leakage. However, the way Pinot uses ZkClient here is for testing purposes only, so we need to just replace the deprecated APIs with updated ones.
---
.../org/apache/pinot/broker/queryquota/TableQueryQuotaManagerTest.java | 2 +-
.../java/org/apache/pinot/broker/routing/TimeBoundaryServiceTest.java | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/pinot-broker/src/test/java/org/apache/pinot/broker/queryquota/TableQueryQuotaManagerTest.java b/pinot-broker/src/test/java/org/apache/pinot/broker/queryquota/TableQueryQuotaManagerTest.java
index 25210eb..5ccd243 100644
--- a/pinot-broker/src/test/java/org/apache/pinot/broker/queryquota/TableQueryQuotaManagerTest.java
+++ b/pinot-broker/src/test/java/org/apache/pinot/broker/queryquota/TableQueryQuotaManagerTest.java
@@ -77,7 +77,7 @@ public class TableQueryQuotaManagerTest {
super(clusterName, instanceName, instanceType, zkAddress);
super._zkclient = new ZkClient(StringUtil.join("/", StringUtils.chomp(ZkStarter.DEFAULT_ZK_STR, "/")),
ZkClient.DEFAULT_SESSION_TIMEOUT, ZkClient.DEFAULT_CONNECTION_TIMEOUT, new ZNRecordSerializer());
- _zkclient.deleteRecursive("/" + clusterName + "/PROPERTYSTORE");
+ _zkclient.deleteRecursively("/" + clusterName + "/PROPERTYSTORE");
_zkclient.createPersistent("/" + clusterName + "/PROPERTYSTORE", true);
setPropertyStore(clusterName);
}
diff --git a/pinot-broker/src/test/java/org/apache/pinot/broker/routing/TimeBoundaryServiceTest.java b/pinot-broker/src/test/java/org/apache/pinot/broker/routing/TimeBoundaryServiceTest.java
index 7f4b200..6058723 100644
--- a/pinot-broker/src/test/java/org/apache/pinot/broker/routing/TimeBoundaryServiceTest.java
+++ b/pinot-broker/src/test/java/org/apache/pinot/broker/routing/TimeBoundaryServiceTest.java
@@ -53,7 +53,7 @@ public class TimeBoundaryServiceTest {
_zkClient = new ZkClient(StringUtil.join("/", StringUtils.chomp(ZkStarter.DEFAULT_ZK_STR, "/")),
ZkClient.DEFAULT_SESSION_TIMEOUT, ZkClient.DEFAULT_CONNECTION_TIMEOUT, new ZNRecordSerializer());
String helixClusterName = "TestTimeBoundaryService";
- _zkClient.deleteRecursive("/" + helixClusterName + "/PROPERTYSTORE");
+ _zkClient.deleteRecursively("/" + helixClusterName + "/PROPERTYSTORE");
_zkClient.createPersistent("/" + helixClusterName + "/PROPERTYSTORE", true);
_propertyStore = new ZkHelixPropertyStore<>(new ZkBaseDataAccessor<ZNRecord>(_zkClient),
"/" + helixClusterName + "/PROPERTYSTORE", null);
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org