[GitHub] [spark] amaliujia commented on a diff in pull request #38842: [SPARK-41326] [CONNECT] Fix deduplicate is missing input

[GitBox <gi...@apache.org>]

amaliujia commented on code in PR #38842:
URL: https://github.com/apache/spark/pull/38842#discussion_r1035289551


##########
python/pyspark/sql/connect/plan.py:
##########
@@ -466,6 +466,7 @@ def __init__(
     def plan(self, session: "SparkConnectClient") -> proto.Relation:
         assert self._child is not None
         plan = proto.Relation()
+        plan.deduplicate.input.CopyFrom(self._child.plan(session))

Review Comment:
   this is a case that probably we have a test in `test_connect_basic` to avoid, maybe BTW add a test case there?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org