You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by mi...@cs.stanford.edu on 2012/12/16 07:19:54 UTC
Re: Review Request: Dynamic reconfiguration,
see https://issues.apache.org/jira/browse/ZOOKEEPER-107
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6707/#review13756
-----------------------------------------------------------
/src/c/include/zookeeper.h
<https://reviews.apache.org/r/6707/#comment29430>
/src/zookeeper.jute
<https://reviews.apache.org/r/6707/#comment29428>
/src/c/include/zookeeper.h
<https://reviews.apache.org/r/6707/#comment30960>
Could you document the format of the returned data?
/src/c/src/cli.c
<https://reviews.apache.org/r/6707/#comment30955>
bad indentation?
/src/c/src/cli.c
<https://reviews.apache.org/r/6707/#comment30956>
Shouldn't it be "serverId=host:port1:port2:port3"? It might be a good idea to give more descriptive names for the ports.
/src/c/src/zookeeper.c
<https://reviews.apache.org/r/6707/#comment30957>
Don't use STRUCT_INITIALIZER macro.
/src/c/src/zookeeper.c
<https://reviews.apache.org/r/6707/#comment30958>
bad indentation?
/src/c/src/zookeeper.c
<https://reviews.apache.org/r/6707/#comment30959>
Don't use STRUCT_INITIALIZER.
- michim
On Nov. 29, 2012, 7:12 a.m., Alexander Shraer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6707/
> -----------------------------------------------------------
>
> (Updated Nov. 29, 2012, 7:12 a.m.)
>
>
> Review request for zookeeper.
>
>
> Description
> -------
>
> see https://issues.apache.org/jira/browse/ZOOKEEPER-107
>
>
> Diffs
> -----
>
> /src/c/include/proto.h 1415037
> /src/c/include/zookeeper.h 1415037
> /src/c/src/cli.c 1415037
> /src/c/src/zookeeper.c 1415037
> /src/java/main/org/apache/zookeeper/KeeperException.java 1415037
> /src/java/main/org/apache/zookeeper/ZooDefs.java 1415037
> /src/java/main/org/apache/zookeeper/ZooKeeper.java 1415037
> /src/java/main/org/apache/zookeeper/ZooKeeperMain.java 1415037
> /src/java/main/org/apache/zookeeper/cli/GetConfigCommand.java PRE-CREATION
> /src/java/main/org/apache/zookeeper/cli/ReconfigCommand.java PRE-CREATION
> /src/java/main/org/apache/zookeeper/server/DataTree.java 1415037
> /src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java 1415037
> /src/java/main/org/apache/zookeeper/server/NIOServerCnxnFactory.java 1415037
> /src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java 1415037
> /src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java 1415037
> /src/java/main/org/apache/zookeeper/server/Request.java 1415037
> /src/java/main/org/apache/zookeeper/server/ServerCnxnFactory.java 1415037
> /src/java/main/org/apache/zookeeper/server/TraceFormatter.java 1415037
> /src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java 1415037
> /src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java 1415037
> /src/java/main/org/apache/zookeeper/server/quorum/Follower.java 1415037
> /src/java/main/org/apache/zookeeper/server/quorum/FollowerRequestProcessor.java 1415037
> /src/java/main/org/apache/zookeeper/server/quorum/Leader.java 1415037
> /src/java/main/org/apache/zookeeper/server/quorum/Learner.java 1415037
> /src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java 1415037
> /src/java/main/org/apache/zookeeper/server/quorum/Observer.java 1415037
> /src/java/main/org/apache/zookeeper/server/quorum/ObserverRequestProcessor.java 1415037
> /src/java/main/org/apache/zookeeper/server/quorum/QuorumBean.java 1415037
> /src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java 1415037
> /src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 1415037
> /src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java 1415037
> /src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerMain.java 1415037
> /src/java/main/org/apache/zookeeper/server/quorum/QuorumZooKeeperServer.java 1415037
> /src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyRequestProcessor.java 1415037
> /src/java/main/org/apache/zookeeper/server/quorum/flexible/QuorumHierarchical.java 1415037
> /src/java/main/org/apache/zookeeper/server/quorum/flexible/QuorumMaj.java 1415037
> /src/java/main/org/apache/zookeeper/server/quorum/flexible/QuorumVerifier.java 1415037
> /src/java/main/org/apache/zookeeper/server/util/ConfigUtils.java PRE-CREATION
> /src/java/main/org/apache/zookeeper/server/util/SerializeUtils.java 1415037
> /src/java/test/org/apache/zookeeper/server/TruncateCorruptionTest.java 1415037
> /src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerTestBase.java 1415037
> /src/java/test/org/apache/zookeeper/server/quorum/ReconfigRecoveryTest.java PRE-CREATION
> /src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java 1415037
> /src/java/test/org/apache/zookeeper/test/CnxManagerTest.java 1415037
> /src/java/test/org/apache/zookeeper/test/QuorumMajorityTest.java PRE-CREATION
> /src/java/test/org/apache/zookeeper/test/QuorumUtil.java 1415037
> /src/java/test/org/apache/zookeeper/test/ReconfigTest.java PRE-CREATION
> /src/zookeeper.jute 1415037
>
> Diff: https://reviews.apache.org/r/6707/diff/
>
>
> Testing
> -------
>
> New test files were added: ReconfigTest, ReconfigRecoveryTest and QuorumMajorityTest. Many other tests were modified.
>
>
> Thanks,
>
> Alexander Shraer
>
>
Re: Review Request: Dynamic reconfiguration,
see https://issues.apache.org/jira/browse/ZOOKEEPER-107
Posted by Alexander Shraer <sh...@yahoo-inc.com>.
> On Dec. 16, 2012, 6:19 a.m., michim wrote:
> >
all comments are now addressed.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6707/#review13756
-----------------------------------------------------------
On Nov. 29, 2012, 7:12 a.m., Alexander Shraer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6707/
> -----------------------------------------------------------
>
> (Updated Nov. 29, 2012, 7:12 a.m.)
>
>
> Review request for zookeeper.
>
>
> Description
> -------
>
> see https://issues.apache.org/jira/browse/ZOOKEEPER-107
>
>
> Diffs
> -----
>
> /src/c/include/proto.h 1415037
> /src/c/include/zookeeper.h 1415037
> /src/c/src/cli.c 1415037
> /src/c/src/zookeeper.c 1415037
> /src/java/main/org/apache/zookeeper/KeeperException.java 1415037
> /src/java/main/org/apache/zookeeper/ZooDefs.java 1415037
> /src/java/main/org/apache/zookeeper/ZooKeeper.java 1415037
> /src/java/main/org/apache/zookeeper/ZooKeeperMain.java 1415037
> /src/java/main/org/apache/zookeeper/cli/GetConfigCommand.java PRE-CREATION
> /src/java/main/org/apache/zookeeper/cli/ReconfigCommand.java PRE-CREATION
> /src/java/main/org/apache/zookeeper/server/DataTree.java 1415037
> /src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java 1415037
> /src/java/main/org/apache/zookeeper/server/NIOServerCnxnFactory.java 1415037
> /src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java 1415037
> /src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java 1415037
> /src/java/main/org/apache/zookeeper/server/Request.java 1415037
> /src/java/main/org/apache/zookeeper/server/ServerCnxnFactory.java 1415037
> /src/java/main/org/apache/zookeeper/server/TraceFormatter.java 1415037
> /src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java 1415037
> /src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java 1415037
> /src/java/main/org/apache/zookeeper/server/quorum/Follower.java 1415037
> /src/java/main/org/apache/zookeeper/server/quorum/FollowerRequestProcessor.java 1415037
> /src/java/main/org/apache/zookeeper/server/quorum/Leader.java 1415037
> /src/java/main/org/apache/zookeeper/server/quorum/Learner.java 1415037
> /src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java 1415037
> /src/java/main/org/apache/zookeeper/server/quorum/Observer.java 1415037
> /src/java/main/org/apache/zookeeper/server/quorum/ObserverRequestProcessor.java 1415037
> /src/java/main/org/apache/zookeeper/server/quorum/QuorumBean.java 1415037
> /src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java 1415037
> /src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 1415037
> /src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java 1415037
> /src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerMain.java 1415037
> /src/java/main/org/apache/zookeeper/server/quorum/QuorumZooKeeperServer.java 1415037
> /src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyRequestProcessor.java 1415037
> /src/java/main/org/apache/zookeeper/server/quorum/flexible/QuorumHierarchical.java 1415037
> /src/java/main/org/apache/zookeeper/server/quorum/flexible/QuorumMaj.java 1415037
> /src/java/main/org/apache/zookeeper/server/quorum/flexible/QuorumVerifier.java 1415037
> /src/java/main/org/apache/zookeeper/server/util/ConfigUtils.java PRE-CREATION
> /src/java/main/org/apache/zookeeper/server/util/SerializeUtils.java 1415037
> /src/java/test/org/apache/zookeeper/server/TruncateCorruptionTest.java 1415037
> /src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerTestBase.java 1415037
> /src/java/test/org/apache/zookeeper/server/quorum/ReconfigRecoveryTest.java PRE-CREATION
> /src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java 1415037
> /src/java/test/org/apache/zookeeper/test/CnxManagerTest.java 1415037
> /src/java/test/org/apache/zookeeper/test/QuorumMajorityTest.java PRE-CREATION
> /src/java/test/org/apache/zookeeper/test/QuorumUtil.java 1415037
> /src/java/test/org/apache/zookeeper/test/ReconfigTest.java PRE-CREATION
> /src/zookeeper.jute 1415037
>
> Diff: https://reviews.apache.org/r/6707/diff/
>
>
> Testing
> -------
>
> New test files were added: ReconfigTest, ReconfigRecoveryTest and QuorumMajorityTest. Many other tests were modified.
>
>
> Thanks,
>
> Alexander Shraer
>
>