[GitHub] [superset] kgabryje commented on a change in pull request #17587: chore(explore): Migrate BigNumber to v1 api [ID-28][ID-55]

[GitBox <gi...@apache.org>]

kgabryje commented on a change in pull request #17587:
URL: https://github.com/apache/superset/pull/17587#discussion_r767710689



##########
File path: superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberTotal/controlPanel.ts
##########
@@ -51,44 +51,45 @@ export default {
             },
           },
         ],
+      ],
+    },
+    {
+      label: t('Chart Options'),
+      expanded: true,
+      controlSetRows: [
+        [headerFontSize],
+        [subheaderFontSize],
         ['y_axis_format'],
         [
           {
-            name: 'header_format_selector',
+            name: 'time_format',
             config: {
-              type: 'CheckboxControl',
-              label: t('Timestamp Format'),
+              type: 'SelectControl',
+              freeForm: true,
+              label: t('Date format'),
               renderTrigger: true,
-              default: false,
-              description: t('Whether to format the timestamp'),
+              choices: D3_TIME_FORMAT_OPTIONS,
+              description: D3_FORMAT_DOCS,
+              default: smartDateFormatter.id,
             },
           },
         ],
         [
           {
-            name: 'header_timestamp_format',
+            name: 'force_timestamp_formatting',

Review comment:
       We use that control only on frontend, should be compatible with the old version without db migration




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org