[GitHub] brodybits commented on issue #670: [8.0.0] Android environment variables: ANDROID_HOME vs ANDROID_SDK_ROOT

[GitBox <gi...@apache.org>]

brodybits commented on issue #670: [8.0.0] Android environment variables: ANDROID_HOME vs ANDROID_SDK_ROOT
URL: https://github.com/apache/cordova-android/issues/670#issuecomment-463666177
 
 
   > (as I remember you pushed a PR in this area), check
   
   PR #656, which was raised to resolve #617
   
   > Strange [...]?
   
   Yes.
   
   The explanation is that `check_reqs.js` would internally set its own process `ANDROID_HOME` environmental variable according to where it found the right place, in the following inner function: <https://github.com/apache/cordova-android/blob/b4de6f55c4d7ad87a72f852d2b98dc9baf351731/bin/templates/cordova/lib/check_reqs.js#L225-L230>
   
   I resolved #617 without changing how this part works in order to support non-deprecated Android SDK behavior without blocking the major release.
   
   The correct solution would be for `check_reqs.js` to track the correct Android SDK root in an internal variable and then log the value of the internal variable in a user-friendly manner. I just added the **bug** label, cannot promise when I will get a chance to fix it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org