You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yingchun Lai (Code Review)" <ge...@cloudera.org> on 2022/09/16 15:48:47 UTC
[kudu-CR] KUDU-3353 [schema] Support to modify immutable attribute on column schema
Yingchun Lai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18996
Change subject: KUDU-3353 [schema] Support to modify immutable attribute on column schema
......................................................................
KUDU-3353 [schema] Support to modify immutable attribute on column schema
In the previous implemention of adding immutable attribute
to column on C++ client side ec3a9f75b6924a70ecbf08e3805228ad9b92b9f0,
it missed to alter column schema to add/remove immutable attribute.
This patch implements it and adds some tests.
Change-Id: I213957bfb3a87b8e1a92cfd340a2e806d192f9ba
---
M src/kudu/client/client-test.cc
M src/kudu/client/client.cc
M src/kudu/client/schema.cc
M src/kudu/common/common.proto
M src/kudu/common/schema.cc
M src/kudu/common/schema.h
M src/kudu/common/wire_protocol.cc
M src/kudu/integration-tests/alter_table-test.cc
8 files changed, 91 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/96/18996/1
--
To view, visit http://gerrit.cloudera.org:8080/18996
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I213957bfb3a87b8e1a92cfd340a2e806d192f9ba
Gerrit-Change-Number: 18996
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <ac...@gmail.com>
[kudu-CR] KUDU-3353 [schema] Support to modify immutable attribute on column schema
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18996 )
Change subject: KUDU-3353 [schema] Support to modify immutable attribute on column schema
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/18996
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I213957bfb3a87b8e1a92cfd340a2e806d192f9ba
Gerrit-Change-Number: 18996
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Sat, 17 Sep 2022 01:03:28 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3353 [schema] Support to modify immutable attribute on column schema
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18996 )
Change subject: KUDU-3353 [schema] Support to modify immutable attribute on column schema
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18996/2/src/kudu/client/client-test.cc
File src/kudu/client/client-test.cc:
http://gerrit.cloudera.org:8080/#/c/18996/2/src/kudu/client/client-test.cc@9186
PS2, Line 9186: class ClientTestUnixSocket : public ClientTest {
> Do you mean some test cases like in alter_table-test.cc? The tests there ha
Yes, those look good, thanks! It seems I posted my comments prematurely since I was traveling (was in an airport).
--
To view, visit http://gerrit.cloudera.org:8080/18996
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I213957bfb3a87b8e1a92cfd340a2e806d192f9ba
Gerrit-Change-Number: 18996
Gerrit-PatchSet: 3
Gerrit-Owner: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Sat, 24 Sep 2022 23:10:36 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3353 [schema] Support to modify immutable attribute on column schema
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18996 )
Change subject: KUDU-3353 [schema] Support to modify immutable attribute on column schema
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/18996
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I213957bfb3a87b8e1a92cfd340a2e806d192f9ba
Gerrit-Change-Number: 18996
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Sat, 17 Sep 2022 01:44:19 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3353 [schema] Support to modify immutable attribute on column schema
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Yifan Zhang, Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18996
to look at the new patch set (#3).
Change subject: KUDU-3353 [schema] Support to modify immutable attribute on column schema
......................................................................
KUDU-3353 [schema] Support to modify immutable attribute on column schema
In the previous implementation of adding immutable attribute
to column on C++ client side ec3a9f75b6924a70ecbf08e3805228ad9b92b9f0,
it missed to alter column schema to add/remove immutable attribute.
This patch implements it and adds some tests.
Change-Id: I213957bfb3a87b8e1a92cfd340a2e806d192f9ba
---
M src/kudu/client/client-test.cc
M src/kudu/client/client.cc
M src/kudu/client/schema.cc
M src/kudu/common/common.proto
M src/kudu/common/schema.cc
M src/kudu/common/schema.h
M src/kudu/common/wire_protocol.cc
M src/kudu/integration-tests/alter_table-test.cc
8 files changed, 93 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/96/18996/3
--
To view, visit http://gerrit.cloudera.org:8080/18996
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I213957bfb3a87b8e1a92cfd340a2e806d192f9ba
Gerrit-Change-Number: 18996
Gerrit-PatchSet: 3
Gerrit-Owner: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
[kudu-CR] KUDU-3353 [schema] Support to modify immutable attribute on column schema
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/18996 )
Change subject: KUDU-3353 [schema] Support to modify immutable attribute on column schema
......................................................................
Removed reviewer Kudu Jenkins with the following votes:
* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/18996
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I213957bfb3a87b8e1a92cfd340a2e806d192f9ba
Gerrit-Change-Number: 18996
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
[kudu-CR] KUDU-3353 [schema] Support to modify immutable attribute on column schema
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18996 )
Change subject: KUDU-3353 [schema] Support to modify immutable attribute on column schema
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18996/1/src/kudu/client/client-test.cc
File src/kudu/client/client-test.cc:
http://gerrit.cloudera.org:8080/#/c/18996/1/src/kudu/client/client-test.cc@9140
PS1, Line 9140: Compatablity
nit: Compatibility. Same elsewhere.
--
To view, visit http://gerrit.cloudera.org:8080/18996
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I213957bfb3a87b8e1a92cfd340a2e806d192f9ba
Gerrit-Change-Number: 18996
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Fri, 23 Sep 2022 12:00:44 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3353 [schema] Support to modify immutable attribute on column schema
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18996 )
Change subject: KUDU-3353 [schema] Support to modify immutable attribute on column schema
......................................................................
KUDU-3353 [schema] Support to modify immutable attribute on column schema
In the previous implementation of adding immutable attribute
to column on C++ client side ec3a9f75b6924a70ecbf08e3805228ad9b92b9f0,
it missed to alter column schema to add/remove immutable attribute.
This patch implements it and adds some tests.
Change-Id: I213957bfb3a87b8e1a92cfd340a2e806d192f9ba
Reviewed-on: http://gerrit.cloudera.org:8080/18996
Reviewed-by: Alexey Serbin <al...@apache.org>
Tested-by: Alexey Serbin <al...@apache.org>
---
M src/kudu/client/client-test.cc
M src/kudu/client/client.cc
M src/kudu/client/schema.cc
M src/kudu/common/common.proto
M src/kudu/common/schema.cc
M src/kudu/common/schema.h
M src/kudu/common/wire_protocol.cc
M src/kudu/integration-tests/alter_table-test.cc
8 files changed, 93 insertions(+), 10 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/18996
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I213957bfb3a87b8e1a92cfd340a2e806d192f9ba
Gerrit-Change-Number: 18996
Gerrit-PatchSet: 4
Gerrit-Owner: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
[kudu-CR] KUDU-3353 [schema] Support to modify immutable attribute on column schema
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Yifan Zhang, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18996
to look at the new patch set (#2).
Change subject: KUDU-3353 [schema] Support to modify immutable attribute on column schema
......................................................................
KUDU-3353 [schema] Support to modify immutable attribute on column schema
In the previous implemention of adding immutable attribute
to column on C++ client side ec3a9f75b6924a70ecbf08e3805228ad9b92b9f0,
it missed to alter column schema to add/remove immutable attribute.
This patch implements it and adds some tests.
Change-Id: I213957bfb3a87b8e1a92cfd340a2e806d192f9ba
---
M src/kudu/client/client-test.cc
M src/kudu/client/client.cc
M src/kudu/client/schema.cc
M src/kudu/common/common.proto
M src/kudu/common/schema.cc
M src/kudu/common/schema.h
M src/kudu/common/wire_protocol.cc
M src/kudu/integration-tests/alter_table-test.cc
8 files changed, 93 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/96/18996/2
--
To view, visit http://gerrit.cloudera.org:8080/18996
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I213957bfb3a87b8e1a92cfd340a2e806d192f9ba
Gerrit-Change-Number: 18996
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
[kudu-CR] KUDU-3353 [schema] Support to modify immutable attribute on column schema
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18996 )
Change subject: KUDU-3353 [schema] Support to modify immutable attribute on column schema
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18996/1/src/kudu/client/client-test.cc
File src/kudu/client/client-test.cc:
http://gerrit.cloudera.org:8080/#/c/18996/1/src/kudu/client/client-test.cc@9140
PS1, Line 9140: Compatibilit
> nit: Compatibility. Same elsewhere.
Done
--
To view, visit http://gerrit.cloudera.org:8080/18996
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I213957bfb3a87b8e1a92cfd340a2e806d192f9ba
Gerrit-Change-Number: 18996
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Fri, 23 Sep 2022 16:49:28 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3353 [schema] Support to modify immutable attribute on column schema
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/18996 )
Change subject: KUDU-3353 [schema] Support to modify immutable attribute on column schema
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/18996
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I213957bfb3a87b8e1a92cfd340a2e806d192f9ba
Gerrit-Change-Number: 18996
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Fri, 23 Sep 2022 04:04:01 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3353 [schema] Support to modify immutable attribute on column schema
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has removed a vote on this change.
Change subject: KUDU-3353 [schema] Support to modify immutable attribute on column schema
......................................................................
Removed Verified+1 by Yingchun Lai <ac...@gmail.com>
--
To view, visit http://gerrit.cloudera.org:8080/18996
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I213957bfb3a87b8e1a92cfd340a2e806d192f9ba
Gerrit-Change-Number: 18996
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
[kudu-CR] KUDU-3353 [schema] Support to modify immutable attribute on column schema
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18996 )
Change subject: KUDU-3353 [schema] Support to modify immutable attribute on column schema
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
Overall looks good to me, just a few nits and a request to add more test coverage for the newly introduced functionality.
http://gerrit.cloudera.org:8080/#/c/18996/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/18996/2//COMMIT_MSG@9
PS2, Line 9: implemention
implementation
http://gerrit.cloudera.org:8080/#/c/18996/2/src/kudu/client/client-test.cc
File src/kudu/client/client-test.cc:
http://gerrit.cloudera.org:8080/#/c/18996/2/src/kudu/client/client-test.cc@9186
PS2, Line 9186: class ClientTestUnixSocket : public ClientTest {
Does it make sense to add 'positive' tests scenarios to alter a table, toggling the immutable attribute on a column?
Also, it seems in client-test.cc there isn't coverage for 'positive' scenarios to alter a table, adding a column with immutable attribute set. Does it make sense to add such tests as well?
--
To view, visit http://gerrit.cloudera.org:8080/18996
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I213957bfb3a87b8e1a92cfd340a2e806d192f9ba
Gerrit-Change-Number: 18996
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Fri, 23 Sep 2022 17:18:26 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-3353 [schema] Support to modify immutable attribute on column schema
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18996 )
Change subject: KUDU-3353 [schema] Support to modify immutable attribute on column schema
......................................................................
Patch Set 3: Verified+1
unrelated test failures:
* org.apache.kudu.client.TestSecurity (TSAN)
* ErrorType/TabletServerDiskErrorTest.TestRandomOpSequence/2
--
To view, visit http://gerrit.cloudera.org:8080/18996
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I213957bfb3a87b8e1a92cfd340a2e806d192f9ba
Gerrit-Change-Number: 18996
Gerrit-PatchSet: 3
Gerrit-Owner: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Sat, 24 Sep 2022 23:11:38 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-3353 [schema] Support to modify immutable attribute on column schema
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: KUDU-3353 [schema] Support to modify immutable attribute on column schema
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/18996
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I213957bfb3a87b8e1a92cfd340a2e806d192f9ba
Gerrit-Change-Number: 18996
Gerrit-PatchSet: 3
Gerrit-Owner: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
[kudu-CR] KUDU-3353 [schema] Support to modify immutable attribute on column schema
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/18996 )
Change subject: KUDU-3353 [schema] Support to modify immutable attribute on column schema
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/18996/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/18996/2//COMMIT_MSG@9
PS2, Line 9: implemention
> implementation
Done
http://gerrit.cloudera.org:8080/#/c/18996/2/src/kudu/client/client-test.cc
File src/kudu/client/client-test.cc:
http://gerrit.cloudera.org:8080/#/c/18996/2/src/kudu/client/client-test.cc@9186
PS2, Line 9186: class ClientTestUnixSocket : public ClientTest {
> Does it make sense to add 'positive' tests scenarios to alter a table, togg
Do you mean some test cases like in alter_table-test.cc? The tests there have cover the scenarios when the cluster supports 'immutable column attribute' feature:
1. alter column from default (mutable) to Immutable, then check attribute, read and write
2. alter column from immutable to mutable, then check attribute, read and write
3. add a column with immutable attribute, then check attribute, read and write
links:
1. https://gerrit.cloudera.org/c/18996/2/src/kudu/integration-tests/alter_table-test.cc#2555
--
To view, visit http://gerrit.cloudera.org:8080/18996
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I213957bfb3a87b8e1a92cfd340a2e806d192f9ba
Gerrit-Change-Number: 18996
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Sat, 24 Sep 2022 16:03:29 +0000
Gerrit-HasComments: Yes