You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/12/23 07:04:47 UTC
[GitHub] [incubator-nuttx] anchao opened a new pull request #5066: arch/arm/cortex-a/r: dump all registers with alias
anchao opened a new pull request #5066:
URL: https://github.com/apache/incubator-nuttx/pull/5066
## Summary
arch/arm/cortex-a/r: dump all registers with alias
Signed-off-by: chao.an <an...@xiaomi.com>
## Impact
N/A
## Testing
```
up_registerdump: R0: 00000001 R1: 00000000 R2: 00000000 R3: 00000000
up_registerdump: R4: 00000001 R5: 3c2a6800 R6: 3c2dbf64 R7: 00000006
up_registerdump: R8: 3c2aa584 SB: 3c2ab67c SL: 00000000 FP: 00000000
up_registerdump: IP: 00000001 SP: 3c2dd640 LR: 3c02763c PC: 3c027b9c
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5066: arch/arm/cortex-a/r: dump all registers with alias
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #5066:
URL: https://github.com/apache/incubator-nuttx/pull/5066#discussion_r774401294
##########
File path: arch/arm/src/armv7-a/arm_assert.c
##########
@@ -114,13 +112,24 @@ static inline void arm_registerdump(FAR volatile uint32_t *regs)
/* Dump the interrupt registers */
- for (reg = REG_R0; reg <= REG_R15; reg += 8)
- {
- uint32_t *ptr = (uint32_t *)®s[reg];
- _alert("R%d: %08x %08x %08x %08x %08x %08x %08x %08x\n",
- reg, ptr[0], ptr[1], ptr[2], ptr[3],
- ptr[4], ptr[5], ptr[6], ptr[7]);
- }
+ _alert("R0: %08x R1: %08x R2: %08x R3: %08x\n",
+ regs[REG_R0], regs[REG_R1], regs[REG_R2], regs[REG_R3]);
+ _alert("R4: %08x R5: %08x R6: %08x "
Review comment:
need update the old arm too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #5066: arch/arm/cortex-a/r: dump all registers with alias
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #5066:
URL: https://github.com/apache/incubator-nuttx/pull/5066
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] anchao commented on a change in pull request #5066: arch/arm/cortex-a/r: dump all registers with alias
Posted by GitBox <gi...@apache.org>.
anchao commented on a change in pull request #5066:
URL: https://github.com/apache/incubator-nuttx/pull/5066#discussion_r774414104
##########
File path: arch/arm/src/armv7-a/arm_assert.c
##########
@@ -114,13 +112,24 @@ static inline void arm_registerdump(FAR volatile uint32_t *regs)
/* Dump the interrupt registers */
- for (reg = REG_R0; reg <= REG_R15; reg += 8)
- {
- uint32_t *ptr = (uint32_t *)®s[reg];
- _alert("R%d: %08x %08x %08x %08x %08x %08x %08x %08x\n",
- reg, ptr[0], ptr[1], ptr[2], ptr[3],
- ptr[4], ptr[5], ptr[6], ptr[7]);
- }
+ _alert("R0: %08x R1: %08x R2: %08x R3: %08x\n",
+ regs[REG_R0], regs[REG_R1], regs[REG_R2], regs[REG_R3]);
+ _alert("R4: %08x R5: %08x R6: %08x "
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5066: arch/arm/cortex-a/r: dump all registers with alias
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #5066:
URL: https://github.com/apache/incubator-nuttx/pull/5066#discussion_r774417917
##########
File path: arch/arm/src/arm/arm_assert.c
##########
@@ -113,13 +112,14 @@ static inline void arm_registerdump(void)
/* Dump the interrupt registers */
- for (reg = REG_R0; reg <= REG_R15; reg += 8)
- {
- uint32_t *ptr = (uint32_t *)®s[reg];
- _alert("R%d: %08x %08x %08x %08x %08x %08x %08x %08x\n",
- reg, ptr[0], ptr[1], ptr[2], ptr[3],
- ptr[4], ptr[5], ptr[6], ptr[7]);
- }
+ _alert("R0: %08x R1: %08x R2: %08x R3: %08x\n",
+ regs[REG_R0], regs[REG_R1], regs[REG_R2], regs[REG_R3]);
+ _alert("R4: %08x R5: %08x R6: %08x FP: %08x\n",
Review comment:
need check thumb too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org