You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by ueshin <gi...@git.apache.org> on 2017/12/22 08:29:52 UTC
[GitHub] spark pull request #20054: [SPARK-22874][PYSPARK][SQL] Modify checking panda...
GitHub user ueshin opened a pull request:
https://github.com/apache/spark/pull/20054
[SPARK-22874][PYSPARK][SQL] Modify checking pandas version to use LooseVersion.
## What changes were proposed in this pull request?
Currently we check pandas version by capturing if `ImportError` for the specific imports is raised or not but we can compare `LooseVersion` of the version strings as the same as we're checking pyarrow version.
## How was this patch tested?
Existing tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ueshin/apache-spark issues/SPARK-22874
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/20054.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #20054
----
commit 9f6793664ca1e96e549254de9526921eb5094a8a
Author: Takuya UESHIN <ue...@...>
Date: 2017-12-22T08:02:58Z
Modify checking pandas version to use LooseVersion.
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20054: [SPARK-22874][PYSPARK][SQL] Modify checking pandas versi...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20054
**[Test build #85304 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85304/testReport)** for PR 20054 at commit [`21d2d49`](https://github.com/apache/spark/commit/21d2d4982c37f02cb2fdbe612915f827651b80b8).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20054: [SPARK-22874][PYSPARK][SQL] Modify checking panda...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20054#discussion_r158459861
--- Diff: python/pyspark/sql/utils.py ---
@@ -112,6 +112,15 @@ def toJArray(gateway, jtype, arr):
return jarr
+def _require_minimum_pandas_version():
--- End diff --
Ohh. BTW, I think we can just name it `_require_minimum_pandas_version` -> `require_minimum_pandas_version` and `_require_minimum_pyarrow_version` -> `require_minimum_pyarrow_version`. It's fine as is too to me.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20054: [SPARK-22874][PYSPARK][SQL] Modify checking pandas versi...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20054
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20054: [SPARK-22874][PYSPARK][SQL] Modify checking pandas versi...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20054
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20054: [SPARK-22874][PYSPARK][SQL] Modify checking pandas versi...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20054
**[Test build #85305 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85305/testReport)** for PR 20054 at commit [`677f6bc`](https://github.com/apache/spark/commit/677f6bce3f12754848e97293d8bde12819204bb6).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20054: [SPARK-22874][PYSPARK][SQL] Modify checking pandas versi...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20054
Still LGTM
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20054: [SPARK-22874][PYSPARK][SQL] Modify checking pandas versi...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20054
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20054: [SPARK-22874][PYSPARK][SQL] Modify checking pandas versi...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20054
**[Test build #85303 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85303/testReport)** for PR 20054 at commit [`9f67936`](https://github.com/apache/spark/commit/9f6793664ca1e96e549254de9526921eb5094a8a).
* This patch **fails PySpark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20054: [SPARK-22874][PYSPARK][SQL] Modify checking pandas versi...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20054
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85304/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20054: [SPARK-22874][PYSPARK][SQL] Modify checking pandas versi...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20054
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20054: [SPARK-22874][PYSPARK][SQL] Modify checking pandas versi...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20054
**[Test build #85303 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85303/testReport)** for PR 20054 at commit [`9f67936`](https://github.com/apache/spark/commit/9f6793664ca1e96e549254de9526921eb5094a8a).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20054: [SPARK-22874][PYSPARK][SQL] Modify checking panda...
Posted by ueshin <gi...@git.apache.org>.
Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20054#discussion_r158460651
--- Diff: python/pyspark/sql/utils.py ---
@@ -112,6 +112,15 @@ def toJArray(gateway, jtype, arr):
return jarr
+def _require_minimum_pandas_version():
--- End diff --
Sounds good. I'll update them. Thanks!
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20054: [SPARK-22874][PYSPARK][SQL] Modify checking panda...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20054
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20054: [SPARK-22874][PYSPARK][SQL] Modify checking pandas versi...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20054
Merged to master.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20054: [SPARK-22874][PYSPARK][SQL] Modify checking pandas versi...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20054
**[Test build #85306 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85306/testReport)** for PR 20054 at commit [`7ef6887`](https://github.com/apache/spark/commit/7ef68870077d13296b8700bfadb9a5862765351e).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20054: [SPARK-22874][PYSPARK][SQL] Modify checking pandas versi...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20054
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85306/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20054: [SPARK-22874][PYSPARK][SQL] Modify checking pandas versi...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20054
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85305/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20054: [SPARK-22874][PYSPARK][SQL] Modify checking pandas versi...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20054
**[Test build #85304 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85304/testReport)** for PR 20054 at commit [`21d2d49`](https://github.com/apache/spark/commit/21d2d4982c37f02cb2fdbe612915f827651b80b8).
* This patch **fails PySpark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20054: [SPARK-22874][PYSPARK][SQL] Modify checking pandas versi...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20054
**[Test build #85305 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85305/testReport)** for PR 20054 at commit [`677f6bc`](https://github.com/apache/spark/commit/677f6bce3f12754848e97293d8bde12819204bb6).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20054: [SPARK-22874][PYSPARK][SQL] Modify checking pandas versi...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20054
**[Test build #85306 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85306/testReport)** for PR 20054 at commit [`7ef6887`](https://github.com/apache/spark/commit/7ef68870077d13296b8700bfadb9a5862765351e).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20054: [SPARK-22874][PYSPARK][SQL] Modify checking pandas versi...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20054
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85303/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org