[GitHub] [kafka] ijuma commented on a change in pull request #10438: KAFKA-12579: Remove various deprecated clients classes/methods for 3.0

[GitBox <gi...@apache.org>]

ijuma commented on a change in pull request #10438:
URL: https://github.com/apache/kafka/pull/10438#discussion_r607812331



##########
File path: docs/upgrade.html
##########
@@ -27,18 +27,30 @@ <h5><a id="upgrade_300_notable" href="#upgrade_300_notable">Notable changes in 3
         or updating the application not to use internal classes.</li>
     <li>The Streams API removed all deprecated APIs that were deprecated in version 2.5.0 or earlier.
         For a complete list of removed APIs compare the detailed Kafka Streams upgrade notes.</li>
-    <li>The deprecated Scala <code>Authorizer</code>, <code>SimpleAclAuthorizer</code> and related classes have been removed. Please use the Java <code>Authorizer</code>
-        and <code>AclAuthorizer</code> instead.</li>
-    <li>The deprecated <code>Metric#value()</code> method was removed (<a href="https://issues.apache.org/jira/browse/KAFKA-12573">KAFKA-12573</a>).</li>
-    <li>Deprecated security classes were removed: <code>PrincipalBuilder</code>, <code>DefaultPrincipalBuilder</code> and <code>ResourceFilter</code>.
-        Furthermore, deprecated constants and constructors were removed from <code>SslConfigs</code>, <code>SaslConfigs</code>,
-        <code>AclBinding</code> and <code>AclBindingFilter</code>.</li>
-    <li>The deprecated <code>Admin.electedPreferredLeaders()</code> methods were removed. Please use <code>Admin.electLeaders</code> instead.</li>
-    <li>The deprecated <code>kafka-preferred-replica-election</code> command line tool was removed. Please use <code>kafka-leader-election</code> instead.</li>
-    <li>The deprecated <code>ConfigEntry</code> constructor was removed (<a href="https://issues.apache.org/jira/browse/KAFKA-12577">KAFKA-12577</a>).
-        Please use the remaining public constructor instead.</li>
-    <li>The deprecated config value <code>default</code> for the client config <code>client.dns.lookup</code> has been removed. In the unlikely
-        event that you set this config explicitly, we recommend leaving the config unset (<code>use_all_dns_ips</code> is used by default).</li>
+    <li>A number of deprecated classes and methods have been removed in the clients, core and tools modules:</li>

Review comment:
       Addressed.

##########
File path: clients/src/main/java/org/apache/kafka/common/MessageFormatter.java
##########
@@ -34,33 +33,21 @@
  */
 public interface MessageFormatter extends Configurable, Closeable {
 
-    /**
-     * Initialises the MessageFormatter
-     * @param props Properties to configure the formatter
-     * @deprecated Use {@link #configure(Map)} instead, this method is for backward compatibility with the older Formatter interface
-     */
-    @Deprecated

Review comment:
       Good point, done.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org